From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: DWord alignment on ARMv7
Date: Fri, 4 Mar 2016 11:02:10 +0000 [thread overview]
Message-ID: <20160304110210.GA19428@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAKv+Gu8D37DgfbopvB1On_=fNqrBzmCmOCTotX2Lvv6NoSCtvw@mail.gmail.com>
On Fri, Mar 04, 2016 at 11:48:10AM +0100, Ard Biesheuvel wrote:
> I don't think it is the job of the filesystem driver to reason about
> whether get_unaligned_le64() does the right thing under any particular
> configuration. If ARM's implementation of get_unaligned_le64() issues
> load instructions that result in a trap, it is misbehaving and should
> be fixed.
It's not ARMs implementation, we don't have our own implementation, but
we seem to (today) use asm-generic stuff, which is sub-optimal.
Looking at the state of that, I guess we need to implement our own
asm/unaligned.h - and as the asm-generic stuff assumes that all
access sizes fall into the same categories, I'm guessing we'll need
to implement _all_ accessors ourselves.
That really sounds very sub-optimal, but I don't see any other solution
which wouldn't make the asm-generic stuff even more painful to follow
through multiple include files than it already is today.
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-03-04 11:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 22:27 DWord alignment on ARMv7 Marc Kleine-Budde
2016-03-03 23:54 ` Will Deacon
2016-03-04 8:01 ` btrfs_get_token_64() alignment problem on ARM (was: Re: DWord alignment on ARMv7) Marc Kleine-Budde
2016-03-04 9:16 ` David Sterba
2016-03-04 10:48 ` DWord alignment on ARMv7 Ard Biesheuvel
2016-03-04 11:02 ` Russell King - ARM Linux [this message]
2016-03-04 11:14 ` Ard Biesheuvel
2016-03-04 11:19 ` Marc Kleine-Budde
2016-03-04 11:26 ` Ard Biesheuvel
2016-03-04 11:38 ` Arnd Bergmann
2016-03-04 11:44 ` Ard Biesheuvel
2016-03-04 13:30 ` Arnd Bergmann
2016-03-04 13:33 ` Ard Biesheuvel
2016-03-04 13:46 ` Russell King - ARM Linux
2016-03-04 14:41 ` Arnd Bergmann
2016-03-04 14:56 ` Russell King - ARM Linux
2016-03-04 15:49 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160304110210.GA19428@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).