linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 4/6] watchdog: pnx4008: restart: support "cmd" from userspace
Date: Fri, 4 Mar 2016 15:14:56 -0800	[thread overview]
Message-ID: <20160304231456.GA31027@roeck-us.net> (raw)
In-Reply-To: <1457117050-13543-5-git-send-email-slemieux.tyco@gmail.com>

On Fri, Mar 04, 2016 at 01:44:08PM -0500, Sylvain Lemieux wrote:
> From: Sylvain Lemieux <slemieux@tycoint.com>
> 
> Added support to verify if a "cmd" is passed from the userspace program rebooting the system;
> - if a valid "cmd" is available, handle it;
> - If the received "cmd" is not supported, use the default reboot mode.
> 
> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> Changes from v6 to v7:
> - remove typecast.
> 
> Changes from v5 to v6:
> - remove typecast.
> 
> Changes from v4 to v5:
> - no logical change; updated to work with new revision of patch #2.
> 
> Changes from v3 to v4:
> - none.
> 
> Changes from v2 to v3:
> - no logical change; updated to work with new revision of patch #2.
> 
> Changes from v1 to v2:
> - Rename patch title;
>   was "arm: lpc32xx: restart: support "cmd" from userspace"
> - Add change to "pnx-4008" driver instead of "mach-lpc32xx".
> 
>  drivers/watchdog/pnx4008_wdt.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/drivers/watchdog/pnx4008_wdt.c b/drivers/watchdog/pnx4008_wdt.c
> index 51be66e..0529aed 100644
> --- a/drivers/watchdog/pnx4008_wdt.c
> +++ b/drivers/watchdog/pnx4008_wdt.c
> @@ -129,6 +129,21 @@ static int pnx4008_wdt_set_timeout(struct watchdog_device *wdd,
>  static int pnx4008_restart_handler(struct watchdog_device *wdd,
>  				   unsigned long mode, void *cmd)
>  {
> +	const char *boot_cmd = cmd;
> +
> +	/*
> +	 * Verify if a "cmd" passed from the userspace program rebooting
> +	 * the system; if available, handle it.
> +	 * - For details, see the 'reboot' syscall in kernel/reboot.c
> +	 * - If the received "cmd" is not supported, use the default mode.
> +	 */
> +	if (boot_cmd) {
> +		if (boot_cmd[0] == 'h')
> +			mode = REBOOT_HARD;
> +		else if (boot_cmd[0] == 's')
> +			mode = REBOOT_SOFT;
> +	}
> +
>  	if (mode == REBOOT_SOFT) {
>  		/* Force match output active */
>  		writel(EXT_MATCH0, WDTIM_EMR(wdt_base));
> -- 
> 1.8.3.1
> 

  reply	other threads:[~2016-03-04 23:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-04 18:44 [PATCH v7 0/6] watchdog: pnx4008: add restart handler Sylvain Lemieux
2016-03-04 18:44 ` [PATCH v7 1/6] watchdog: pnx4008: update logging during power-on Sylvain Lemieux
2016-03-04 18:44 ` [PATCH v7 2/6] watchdog: pnx4008: add restart handler Sylvain Lemieux
2016-03-04 18:44 ` [PATCH v7 3/6] watchdog: pnx4008: add support for soft reset Sylvain Lemieux
2016-03-04 18:44 ` [PATCH v7 4/6] watchdog: pnx4008: restart: support "cmd" from userspace Sylvain Lemieux
2016-03-04 23:14   ` Guenter Roeck [this message]
2016-03-04 18:44 ` [PATCH v7 5/6] arm: lpc32xx: phy3250 remove restart hook Sylvain Lemieux
2016-03-04 23:18   ` Guenter Roeck
2016-03-04 18:44 ` [PATCH v7 6/6] arm: lpc32xx: remove restart handler Sylvain Lemieux
2016-03-04 23:18   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160304231456.GA31027@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).