linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: edubezval@gmail.com (Eduardo Valentin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/5] thermal: change "hysteresis" as optional property
Date: Tue, 8 Mar 2016 12:55:59 -0800	[thread overview]
Message-ID: <20160308205558.GA7010@localhost.localdomain> (raw)
In-Reply-To: <20160308135743.GC4921@leoy-linaro>

On Tue, Mar 08, 2016 at 09:57:43PM +0800, Leo Yan wrote:
> Hi Eduardo,
> 
> On Fri, Mar 04, 2016 at 11:57:53AM +0000, Javi Merino wrote:
> > On Fri, Mar 04, 2016 at 11:03:49AM +0800, Leo Yan wrote:
> > > On Thu, Mar 03, 2016 at 08:29:44AM -0800, Eduardo Valentin wrote:
> > > > On Fri, Feb 26, 2016 at 11:43:43AM +0800, Leo Yan wrote:
> 
> [...]
> 
> > > > > The property "hysteresis" is mandatory for trip points, so if without
> > > > > it the thermal zone cannot register successfully. But "hysteresis" is
> > > > > ignored in the thermal subsystem and only inquired by several thermal
> > > > > sensor drivers.
> > > > 
> > > > If the Linux thermal subsystem has a problem with handling hysteresis, I
> > > > would rather fix Linux code than relaxing the DT binding. Or if you
> > > > still believe hysteresis is really optional, I would prefer to see a
> > > > better justification than "Linux ignores it".
> > 
> > I see it the other way round, Is hysteresis a property that, without
> > it, the thermal code can't configure itself so it fails to create the
> > trip point?  The current code goes "There is no hysteresis for this
> > property, I don't know how to set up this trip point!".  I think we
> > can do better than this.
> 
> Do you agree with Javi's suggestion? If you think it's okay, I will
> move on to send out a new version patch based on Javi's comments.

No I don't. This discussion so far has been about Linux code. I still
havent seen an argument explaining why hysteresis has to be optional.

BR,

> 
> Thanks,
> Leo Yan

  reply	other threads:[~2016-03-08 20:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26  3:43 [PATCH v2 0/5] thermal: hisilicon: enable power allocator for Hi6220 Leo Yan
2016-02-26  3:43 ` [PATCH v2 1/5] thermal: change "hysteresis" as optional property Leo Yan
2016-03-03 10:45   ` Javi Merino
2016-03-03 16:29   ` Eduardo Valentin
2016-03-04  3:03     ` Leo Yan
2016-03-04 11:57       ` Javi Merino
2016-03-08 13:57         ` Leo Yan
2016-03-08 20:55           ` Eduardo Valentin [this message]
2016-03-09 11:10             ` Javi Merino
2016-03-20 15:40               ` Leo Yan
2016-02-26  3:43 ` [PATCH v2 2/5] thermal: hisilicon: support to use any sensor Leo Yan
2016-02-26  3:43 ` [PATCH v2 3/5] thermal: hisilicon: fix IRQ imbalance enabling Leo Yan
2016-02-26  3:43 ` [PATCH v2 4/5] arm64: dts: register Hi6220's thermal sensor Leo Yan
2016-02-26  3:43 ` [PATCH v2 5/5] arm64: dts: register Hi6220's thermal zone for power allocator Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160308205558.GA7010@localhost.localdomain \
    --to=edubezval@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).