From: jan.glauber@caviumnetworks.com (Jan Glauber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] bus: arm-ccn: Fix cpu notifier priority
Date: Thu, 10 Mar 2016 15:34:55 +0100 [thread overview]
Message-ID: <20160310143455.GA9998@hardcore> (raw)
In-Reply-To: <1457512845.22102.113.camel@arm.com>
On Wed, Mar 09, 2016 at 08:40:45AM +0000, Pawel Moll wrote:
> On Tue, 2016-03-08 at 13:14 +0100, Jan Glauber wrote:
> > Fix cpu priority of notifier block that was erroneously set to
> > return value of next statement.
> >
> > Signed-off-by: Jan Glauber <jglauber@cavium.com>
> > ---
> > drivers/bus/arm-ccn.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/bus/arm-ccn.c b/drivers/bus/arm-ccn.c
> > index 7082c72..d4a939e 100644
> > --- a/drivers/bus/arm-ccn.c
> > +++ b/drivers/bus/arm-ccn.c
> > @@ -1271,7 +1271,7 @@ static int arm_ccn_pmu_init(struct arm_ccn
> > *ccn)
> > * picked to have a chance to migrate events before perf is
> > notified.
> > */
> > ccn->dt.cpu_nb.notifier_call = arm_ccn_pmu_cpu_notifier;
> > - ccn->dt.cpu_nb.priority = CPU_PRI_PERF + 1,
> > + ccn->dt.cpu_nb.priority = CPU_PRI_PERF + 1;
> > err = register_cpu_notifier(&ccn->dt.cpu_nb);
> > if (err)
> > goto error_cpu_notifier;
>
> Damn, of course! I have never made (or heard about) such a typo before
> - I wish the compiler warned about it :-(
Hi Pawel,
actually my patch description is wrong. The compiler evaluates both
statements but does _not_ overwrite the value of the first statement
(would require parenthesis to do so). So it is just a cosmetical
change, feel free to drop it.
Sorry for the noise,
Jan
> By all means:
>
> Acked-by: Pawel Moll <pawel.moll@arm.com>
> Cc: <stable@vger.kernel.org> # 4.2+
>
> Arnd, would you be still able to pick it up in this cycle?
>
> Thanks Both!
>
> Pawe?
next prev parent reply other threads:[~2016-03-10 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 12:14 [PATCH] bus: arm-ccn: Fix cpu notifier priority Jan Glauber
2016-03-09 8:40 ` Pawel Moll
2016-03-09 14:24 ` Jan Glauber
2016-03-10 14:34 ` Jan Glauber [this message]
2016-03-10 14:56 ` Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160310143455.GA9998@hardcore \
--to=jan.glauber@caviumnetworks.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).