From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 00/52] mtd: rework ECC layout definition
Date: Thu, 10 Mar 2016 11:06:01 -0800 [thread overview]
Message-ID: <20160310190601.GC2545@google.com> (raw)
In-Reply-To: <1457344062-11633-1-git-send-email-boris.brezillon@free-electrons.com>
On Mon, Mar 07, 2016 at 10:46:50AM +0100, Boris Brezillon wrote:
> Hello,
>
> This patchset aims at getting rid of the nand_ecclayout limitations.
> struct nand_ecclayout is defining fixed eccpos and oobfree arrays which
> can only be increased by modifying the MTD_MAX_ECCPOS_ENTRIES_LARGE and
> MTD_MAX_OOBFREE_ENTRIES_LARGE macros.
> This approach forces us to modify the macro values each time we add a
> new NAND chip with a bigger OOB area, and increasing these arrays also
> penalize all platforms, even those who only support small NAND devices
> (with small OOB area).
>
> The idea to overcome this limitation, is to define the ECC/OOB layout
> by the mean of two functions: ->ecc() and ->free(), which will
> basically return the same information has those stored in the
> nand_ecclayout struct.
>
> Another advantage of this solution is that ECC layouts are usually
> following a repetitive pattern (i.e. leave X bytes free and put Y bytes
> of ECC per ECC chunk), which allows one to implement the ->ecc()
> and ->free() functions with a simple logic that can be applied
> to any size of OOB.
>
> Patches 1 to 4 are just cleanups or trivial fixes that can be taken
> independently.
>
> Also note that the last two commits are removing the nand_ecclayout
> definition, thus preventing any new driver to use this structure.
> Of course, this step can be delayed if some of the previous patches
> are not accepted.
>
> All those changes are available here [1].
>
> Best Regards,
>
> Boris
>
> [1]https://github.com/bbrezillon/linux-0day/tree/nand/ecclayout
FYI, I've pushed patches 1-4 to l2-mtd.git. I'll take another look at
them this week I hope (or your new fellow, Richard, can!), then you can
queue them up for the next cycle.
Brian
prev parent reply other threads:[~2016-03-10 19:06 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 9:46 [PATCH v4 00/52] mtd: rework ECC layout definition Boris Brezillon
2016-03-07 9:46 ` [PATCH v4 01/52] mtd: kill the ecclayout->oobavail field Boris Brezillon
2016-03-07 9:46 ` [PATCH v4 02/52] mtd: create an mtd_oobavail() helper and make use of it Boris Brezillon
2016-03-07 9:46 ` [PATCH v4 03/52] mtd: mtdswap: remove useless if (!mtd->ecclayout) test Boris Brezillon
2016-03-07 9:46 ` [PATCH v4 04/52] mtd: nand: simplify nand_bch_init() usage Boris Brezillon
2016-03-07 9:46 ` [PATCH v4 05/52] mtd: add mtd_ooblayout_xxx() helper functions Boris Brezillon
2016-03-07 9:46 ` [PATCH v4 06/52] mtd: use mtd_ooblayout_xxx() helpers where appropriate Boris Brezillon
2016-03-07 9:46 ` [PATCH v4 07/52] mtd: nand: core: " Boris Brezillon
2016-03-07 9:46 ` [PATCH v4 08/52] mtd: nand: atmel: " Boris Brezillon
2016-03-07 9:46 ` [PATCH v4 09/52] mtd: nand: fsl_ifc: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 10/52] mtd: nand: gpmi: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 11/52] mtd: nand: lpc32xx: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 12/52] mtd: nand: omap2: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 13/52] mtd: onenand: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 14/52] mtd: add mtd_set_ecclayout() helper function Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 15/52] mtd: use mtd_set_ecclayout() where appropriate Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 16/52] mtd: nand: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 17/52] mtd: onenand: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 18/52] mtd: docg3: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 19/52] mtd: create an mtd_ooblayout_ops struct to ease ECC layout definition Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 20/52] mtd: docg3: switch to mtd_ooblayout_ops Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 21/52] mtd: nand: implement the default mtd_ooblayout_ops Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 22/52] mtd: nand: bch: switch to mtd_ooblayout_ops Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 23/52] mtd: nand: sharpsl: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 24/52] mtd: nand: jz4740: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 25/52] mtd: nand: atmel: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 26/52] mtd: nand: bf5xx: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 27/52] mtd: nand: brcm: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 28/52] mtd: nand: cafe: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 29/52] mtd: nand: davinci: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 30/52] mtd: nand: denali: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 31/52] mtd: nand: diskonchip: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 32/52] mtd: nand: docg4: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 33/52] mtd: nand: fsl_elbc: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 34/52] mtd: nand: fsl_ifc: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 35/52] mtd: nand: fsmc: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 36/52] mtd: nand: fsmc: get rid of the fsmc_nand_eccplace struct Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 37/52] mtd: nand: gpmi: switch to mtd_ooblayout_ops Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 38/52] mtd: nand: hisi504: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 39/52] mtd: nand: jz4780: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 40/52] mtd: nand: lpc32xx: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 41/52] mtd: nand: mxc: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 42/52] mtd: nand: omap2: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 43/52] mtd: nand: pxa3xx: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 44/52] mtd: nand: s3c2410: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 45/52] mtd: nand: sh_flctl: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 46/52] mtd: nand: sm_common: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 47/52] mtd: nand: sunxi: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 48/52] mtd: nand: vf610: " Boris Brezillon
2016-03-07 18:04 ` Stefan Agner
2016-03-07 9:47 ` [PATCH v4 49/52] mtd: onenand: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 50/52] staging: mt29f_spinand: " Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 51/52] mtd: nand: kill the ecc->layout field Boris Brezillon
2016-03-07 9:47 ` [PATCH v4 52/52] mtd: kill the nand_ecclayout struct Boris Brezillon
2016-03-10 19:06 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160310190601.GC2545@google.com \
--to=computersforpeace@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).