[PATCH v3 6/6] arm64: dts: r8a7795: Add SYSC PM domains

[PATCH v3 6/6] arm64: dts: r8a7795: Add SYSC PM domains

[Simon Horman]

On Wed, Mar 09, 2016 at 08:18:55PM +0100, Geert Uytterhoeven wrote:
> Add a device node for the System Controller.
> Hook up the Cortex-A57 CPU cores and the Cortex-A57 and Cortex A53 L2
> caches/SCUs to their respective PM domains.
> Hook up all devices that are part of the CPG/MSSR Clock Domain to the
> SYSC "always-on" PM Domain.

[snip]

> +		sysc: system-controller at e6180000 {
> +			compatible = "renesas,r8a7795-sysc";
> +			reg = <0 0xe6180000 0 0x0400>;

In table 9.2 of v0.51e of the documentation I see some registers
beyond the 0x400 range above. Perhaps it could be enlarged accordingly?

> +			#power-domain-cells = <1>;
> +		};

[snip]

[PATCH v3 6/6] arm64: dts: r8a7795: Add SYSC PM domains

[Geert Uytterhoeven]

Hi Simon,

On Fri, Mar 11, 2016 at 12:34 AM, Simon Horman <horms@verge.net.au> wrote:
> On Wed, Mar 09, 2016 at 08:18:55PM +0100, Geert Uytterhoeven wrote:
>> Add a device node for the System Controller.
>> Hook up the Cortex-A57 CPU cores and the Cortex-A57 and Cortex A53 L2
>> caches/SCUs to their respective PM domains.
>> Hook up all devices that are part of the CPG/MSSR Clock Domain to the
>> SYSC "always-on" PM Domain.
>
> [snip]
>
>> +             sysc: system-controller at e6180000 {
>> +                     compatible = "renesas,r8a7795-sysc";
>> +                     reg = <0 0xe6180000 0 0x0400>;
>
> In table 9.2 of v0.51e of the documentation I see some registers
> beyond the 0x400 range above. Perhaps it could be enlarged accordingly?

No, these registers do not apply to R-Car H3.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH v3 6/6] arm64: dts: r8a7795: Add SYSC PM domains

[Simon Horman]

On Fri, Mar 11, 2016 at 09:01:09AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Mar 11, 2016 at 12:34 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Mar 09, 2016 at 08:18:55PM +0100, Geert Uytterhoeven wrote:
> >> Add a device node for the System Controller.
> >> Hook up the Cortex-A57 CPU cores and the Cortex-A57 and Cortex A53 L2
> >> caches/SCUs to their respective PM domains.
> >> Hook up all devices that are part of the CPG/MSSR Clock Domain to the
> >> SYSC "always-on" PM Domain.
> >
> > [snip]
> >
> >> +             sysc: system-controller at e6180000 {
> >> +                     compatible = "renesas,r8a7795-sysc";
> >> +                     reg = <0 0xe6180000 0 0x0400>;
> >
> > In table 9.2 of v0.51e of the documentation I see some registers
> > beyond the 0x400 range above. Perhaps it could be enlarged accordingly?
> 
> No, these registers do not apply to R-Car H3.

True.

In that case I'm fine with all the patches in this series.