From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 04/11] ARM: bcm2835: dt: add bindings for shared interrupt properties
Date: Fri, 11 Mar 2016 11:23:56 +0530 [thread overview]
Message-ID: <20160311055356.GM11154@localhost> (raw)
In-Reply-To: <3503D512-7E9C-46E8-91C7-CAD828DD48D1@martin.sperl.org>
On Tue, Mar 08, 2016 at 12:23:51PM +0100, Martin Sperl wrote:
>
> > On 08.03.2016, at 00:24, Eric Anholt <eric@anholt.net> wrote:
> >
> > kernel at martin.sperl.org writes:
> >
> >> From: Martin Sperl <kernel@martin.sperl.org>
> >>
> >> Add binding documentation for the new shared interrupt properties:
> >> * brcm,dma-channel-shared-mask
> >> * brcm,dma-shared-irq-index
> >>
> >> Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
> >> ---
> >> Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt
> >> index 1396078..f9e84ee 100644
> >> --- a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt
> >> +++ b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt
> >> @@ -17,6 +17,10 @@ Required properties:
> >> - brcm,dma-channel-mask: Bit mask representing the channels
> >> not used by the firmware in ascending order,
> >> i.e. first channel corresponds to LSB.
> >> +- brcm,dma-channel-shared-mask: Bit mask representing the channels
> >> + that use a shared interrupt
> >> +- brcm,dma-shared-irq-index: index of which of the interrupts mentioned
> >> + above is the shared interrupt
> >
> > This should be under "Optional properties" since there are appropriate
> > defaults for the only compatible string listed.
>
> Well - IMO it is actually required and the defaults are only for backwards
> compatibility with older device-trees, but that is easy to change?
> >
> > I still don't think exposing this in the DT is necessary (it's hardware
> > block internals), but I'm not writing the code so I'm fine with it
> Actually this was a request by Vinod to make this configurable via the
> device-tree.
DT needs to provide the hardware details for driver to work across
generations. Driver needs to get information like this to make decisions and
not hard code and make driver not scale..
>
> > either way, really. Regardless, it would be really good to get the
> > slave_sg part of the series in, which is really important for the
> > platform.
> Yes, then we can bring the DMA implementations for mmc/sdhost forward.
>
> Martin
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
~Vinod
next prev parent reply other threads:[~2016-03-11 5:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-05 10:52 [PATCH v3 00/11] dmaengine: bcm2835: bugfix + enhancement of driver kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 01/11] dmaengine: bcm2835: set residue_granularity field kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 02/11] dmaengine: bcm2835: remove unnecessary masking of dma channels kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 03/11] dmaengine: bcm2835: use shared interrupt for channel 11 to 14 kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 04/11] ARM: bcm2835: dt: add bindings for shared interrupt properties kernel at martin.sperl.org
2016-03-07 23:24 ` Eric Anholt
2016-03-08 11:23 ` Martin Sperl
2016-03-11 5:53 ` Vinod Koul [this message]
2016-03-10 8:57 ` Mark Rutland
2016-03-11 8:51 ` Martin Sperl
2016-03-22 9:23 ` Martin Sperl
2016-03-22 10:24 ` Mark Rutland
2016-03-05 10:52 ` [PATCH v3 05/11] dmaengine: bcm2835: add additional defines for DMA-registers kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 06/11] dmaengine: bcm2835: move cyclic member from bcm2835_chan into bcm2835_desc kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 07/11] dmaengine: bcm2835: move controlblock chain generation into separate method kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 08/11] dmaengine: bcm2835: limit max length based on channel type kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 09/11] dmaengine: bcm2835: add slave_sg support to bcm2835-dma kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 10/11] dmaengine: bcm2835: add dma_memcopy " kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 11/11] dmaengine: bcm2835: expose dma registers via debugfs kernel at martin.sperl.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311055356.GM11154@localhost \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).