From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] dmaengine: sun6i: Add cyclic capability
Date: Fri, 11 Mar 2016 13:02:18 +0530 [thread overview]
Message-ID: <20160311073218.GT11154@localhost> (raw)
In-Reply-To: <350ad364b3e46f53159ff71aa611c432b4c588e0.1457606136.git.moinejf@free.fr>
On Thu, Mar 10, 2016 at 11:21:34AM +0100, Jean-Francois Moine wrote:
> +
> + if (vchan->cyclic && vchan->phy && vchan->phy->desc)
> + return NULL;
why check for vchan->cyclic? you are setting that at the end!
> @@ -792,6 +903,11 @@ static void sun6i_dma_issue_pending(struct dma_chan *chan)
> spin_lock_irqsave(&vchan->vc.lock, flags);
>
> if (vchan_issue_pending(&vchan->vc)) {
> + if (vchan->phy && vchan->cyclic) {
> + sun6i_dma_start_desc(vchan);
> + goto out;
> + }
Why should this be cyclic specfic, Channel start should be same for all
channels?
> +static int sun6i_dma_alloc_chan_resources(struct dma_chan *chan)
> +{
> + struct sun6i_vchan *vchan = to_sun6i_vchan(chan);
> +
> + vchan->cyclic = false;
why do you need to set this here?
--
~Vinod
prev parent reply other threads:[~2016-03-11 7:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 10:35 [PATCH 0/5] dmaengine: sun6i: Fixes and upgrade for audio transfers Jean-Francois Moine
2016-03-10 9:15 ` [PATCH 1/5] dmaengine: sun6i: Fix the access of the IRQ register Jean-Francois Moine
2016-03-11 6:39 ` Vinod Koul
2016-03-11 7:16 ` Jean-Francois Moine
2016-03-11 10:56 ` Maxime Ripard
2016-03-10 9:27 ` [PATCH 2/5] dmaengine: sun6i: Fix impossible settings of burst and bus width Jean-Francois Moine
2016-03-11 6:42 ` Vinod Koul
2016-03-11 7:20 ` Jean-Francois Moine
2016-03-11 10:58 ` Maxime Ripard
2016-03-10 9:56 ` [PATCH 3/5] dmaengine: sun6i: Add 4 as a possible bust value Jean-Francois Moine
2016-03-10 19:52 ` Sergei Shtylyov
2016-03-10 10:07 ` [PATCH 4/5] dmaengine: sun6i: Set default values to burst and bus width Jean-Francois Moine
2016-03-11 6:47 ` Vinod Koul
2016-03-10 10:21 ` [PATCH 5/5] dmaengine: sun6i: Add cyclic capability Jean-Francois Moine
2016-03-11 7:32 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311073218.GT11154@localhost \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).