From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: sun8i-q8-common: Do not set constraints on dc1sw regulator
Date: Tue, 15 Mar 2016 19:29:54 +0100 [thread overview]
Message-ID: <20160315182954.GH30977@lukather> (raw)
In-Reply-To: <1457552339-400-2-git-send-email-hdegoede@redhat.com>
On Wed, Mar 09, 2016 at 08:38:59PM +0100, Hans de Goede wrote:
> dc1sw is an on/off only regulator and as such it cannot have constraints.
>
> This is a limitation of the kernel regulator implementation which resolves
> supplies on the first regulator_get(), which is done after applying
> constraints, and applying the constrains will fail because it calls
> _regulator_get_voltage() and _regulator_do_set_voltage() both of which
> will fail on a switch regulator when there is no supply (yet).
>
> This causes registering of all axp22x regulators to fail with the
> following errors:
>
> [ 1.395249] vcc-lcd: failed to get the current voltage(-22)
> [ 1.405131] axp20x-regulator axp20x-regulator: Failed to register dc1sw
> [ 1.412436] axp20x-regulator: probe of axp20x-regulator failed with error -22
>
> This commit removes the constrains on dc1sw / vcc-lcd fixing this problem
> note that dcdc1 itself is contrained to the exact same values, so this
> does not change anything.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Queued this as fixes for 4.6.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160315/9b6b9b45/attachment-0001.sig>
prev parent reply other threads:[~2016-03-15 18:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 19:38 [PATCH 0/1] ARM: dts: sun8i-q8-common: Do not set constraints on dc1sw Hans de Goede
2016-03-09 19:38 ` [PATCH] ARM: dts: sun8i-q8-common: Do not set constraints on dc1sw regulator Hans de Goede
2016-03-15 18:29 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315182954.GH30977@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox