public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] pwm: pwm-tiehrpwm: Update dt binding document to use generic node name
Date: Thu, 17 Mar 2016 10:03:05 -0500	[thread overview]
Message-ID: <20160317150305.GA27356@rob-hp-laptop> (raw)
In-Reply-To: <1457380318-15452-6-git-send-email-fcooper@ti.com>

On Mon, Mar 07, 2016 at 01:51:58PM -0600, Franklin S Cooper Jr wrote:
> Now that the node name has been changed from ehrpwm to pwm the document
> should show this proper usage. Also change the unit address in the example
> from 0 to the proper physical address value that should be used.
> 
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>  Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
> index 9c100b2..20211ed 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
> +++ b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
> @@ -15,14 +15,14 @@ Optional properties:
>  
>  Example:
>  
> -ehrpwm0: ehrpwm at 0 { /* EHRPWM on am33xx */
> +ehrpwm0: pwm at 48300200 { /* EHRPWM on am33xx */
>  	compatible = "ti,am33xx-ehrpwm";
>  	#pwm-cells = <3>;
>  	reg = <0x48300200 0x100>;
>  	ti,hwmods = "ehrpwm0";
>  };
>  
> -ehrpwm0: ehrpwm at 0 { /* EHRPWM on da850 */
> +ehrpwm0: pwm at 01f00000 { /* EHRPWM on da850 */

No leading 0s, but more importantly the address is wrong.

>  	compatible = "ti,da850-ehrpwm", "ti,am33xx-ehrpwm";
>  	#pwm-cells = <3>;
>  	reg = <0x300000 0x2000>;
> -- 
> 2.7.0
> 

  reply	other threads:[~2016-03-17 15:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-07 19:51 [PATCH 0/5] ARM: am335x/am437x: Correct pwm bindings Franklin S Cooper Jr
2016-03-07 19:51 ` [PATCH 1/5] clk: ti: am335x/am4372: Add tbclk to pwm node Franklin S Cooper Jr
2016-04-16  0:46   ` Stephen Boyd
2016-03-07 19:51 ` [PATCH 2/5] ARM: DTS: da850/am4372/am33xx: Use generic node name for ehrpwm Franklin S Cooper Jr
2016-03-07 19:51 ` [PATCH 3/5] ARM: DTS: am33xx: Set pwmss ranges property to an empty value Franklin S Cooper Jr
2016-03-07 19:51 ` [PATCH 4/5] pwm: pwm-tipwmss: Update documentation to use empty range property Franklin S Cooper Jr
2016-03-17 15:01   ` Rob Herring
2016-03-17 16:56     ` Franklin S Cooper Jr.
2016-03-17 21:29       ` Franklin S Cooper Jr.
2016-03-07 19:51 ` [PATCH 5/5] pwm: pwm-tiehrpwm: Update dt binding document to use generic node name Franklin S Cooper Jr
2016-03-17 15:03   ` Rob Herring [this message]
2016-03-17 16:49     ` Franklin S Cooper Jr.
2016-03-17 18:00       ` Rob Herring
2016-03-17 18:20         ` Franklin S Cooper Jr.
2016-03-17 18:56           ` Rob Herring
2016-03-17 19:25             ` Franklin S Cooper Jr.
2016-03-17 19:48               ` Rob Herring
2016-03-17 19:51                 ` Franklin S Cooper Jr.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160317150305.GA27356@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox