linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] dmaengine: sun6i: Add 4 as a possible burst value for the H3
Date: Mon, 21 Mar 2016 08:29:18 +0100	[thread overview]
Message-ID: <20160321072918.GV30977@lukather> (raw)
In-Reply-To: <8485d9976f327cf23e051f64c3a3c5cbff4214a7.1458311540.git.moinejf@free.fr>

On Fri, Mar 18, 2016 at 03:12:26PM +0100, Jean-Francois Moine wrote:
> The H3 accepts 4 as a burst value.
> 
> Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
> ---
>  drivers/dma/sun6i-dma.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
> index ce1e4d6..9378fda 100644
> --- a/drivers/dma/sun6i-dma.c
> +++ b/drivers/dma/sun6i-dma.c
> @@ -101,6 +101,7 @@ struct sun6i_dma_config {
>  	u32 nr_max_channels;
>  	u32 nr_max_requests;
>  	u32 nr_max_vchans;
> +	u32 burst_4;
>  };
>  
>  /*
> @@ -238,6 +239,8 @@ static inline s8 convert_burst(u32 maxburst)
>  	switch (maxburst) {
>  	case 1:
>  		return 0;
> +	case 4:
> +		return 1;
>  	case 8:
>  		return 2;
>  	default:
> @@ -470,6 +473,10 @@ static int set_config(struct sun6i_dma_dev *sdev,
>  {
>  	s8 src_width, dst_width, src_burst, dst_burst;
>  
> +	if (!sdev->cfg->burst_4 &&
> +	    (sconfig->src_maxburst == 4 || sconfig->dst_maxburst == 4))
> +		return -EINVAL;
> +

I still believe this should be dealt with at the framework level.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160321/b12e55d5/attachment.sig>

  reply	other threads:[~2016-03-21  7:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18 14:32 [PATCH v3 0/5] dmaengine: sun6i: Upgrade for audio transfers Jean-Francois Moine
2016-03-18 11:50 ` [PATCH v3 1/5] dmaengine: sun6i: Simplify and fix lli setting Jean-Francois Moine
2016-03-21  7:27   ` Maxime Ripard
2016-03-18 14:12 ` [PATCH v3 2/5] dmaengine: sun6i: Add 4 as a possible burst value for the H3 Jean-Francois Moine
2016-03-21  7:29   ` Maxime Ripard [this message]
2016-03-21  8:35     ` Jean-Francois Moine
2016-03-29  6:46       ` Maxime Ripard
2016-03-29  9:03         ` Jean-Francois Moine
2016-03-18 14:18 ` [PATCH v3 3/5] dmaengine: sun6i: Add cyclic capability Jean-Francois Moine
2016-03-21  7:33   ` Maxime Ripard
2016-03-18 14:21 ` [PATCH v3 4/5] dmaengine: sun6i: Simplify some macros Jean-Francois Moine
2016-03-21  7:48   ` Maxime Ripard
2016-03-21 14:40     ` Jean-Francois Moine
2016-03-18 14:25 ` [PATCH v3 5/5] dmaengine: sun6i: Compact a bit some config constants Jean-Francois Moine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160321072918.GV30977@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).