linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: peterz@infradead.org (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] nmi_backtrace: generate one-line reports for idle cpus
Date: Mon, 21 Mar 2016 16:42:01 +0100	[thread overview]
Message-ID: <20160321154201.GA6344@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1458147733-29338-5-git-send-email-cmetcalf@mellanox.com>

On Wed, Mar 16, 2016 at 01:02:13PM -0400, Chris Metcalf wrote:
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index 9f7c21c22477..d569ae7fde37 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -298,7 +298,7 @@ void arch_cpu_idle(void)
>  /*
>   * We use this if we don't have any better idle routine..
>   */
> -void default_idle(void)
> +void __cpuidle default_idle(void)
>  {
>  	trace_cpu_idle_rcuidle(1, smp_processor_id());
>  	safe_halt();
> @@ -413,7 +413,7 @@ static int prefer_mwait_c1_over_halt(const struct cpuinfo_x86 *c)
>   * with interrupts enabled and no flags, which is backwards compatible with the
>   * original MWAIT implementation.
>   */
> -static void mwait_idle(void)
> +static __cpuidle void mwait_idle(void)
>  {
>  	if (!current_set_polling_and_test()) {
>  		trace_cpu_idle_rcuidle(1, smp_processor_id());

The most common idle function for x86 is: mwait_idle_with_hints(),
trouble is, its an inline, so I'm not sure adding __cpuidle to it does
anything.

I've yet to find the magic objdump incantation to check. Or rather
objdump -h doesn't appear to list .cpuidle.text at all :/

I'm probably doing something silly...

  parent reply	other threads:[~2016-03-21 15:42 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160307204317.GR6344@twins.programming.kicks-ass.net>
2016-03-16 17:02 ` [PATCH v2 0/4] improvements to the nmi_backtrace code Chris Metcalf
2016-03-16 17:02   ` [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-03-17 19:36     ` Peter Zijlstra
2016-03-17 22:31       ` Chris Metcalf
2016-03-17 22:38         ` Peter Zijlstra
2016-03-17 22:41           ` Chris Metcalf
2016-03-17 23:14             ` Peter Zijlstra
2016-03-17 22:55       ` Paul E. McKenney
2016-03-17 23:09         ` Peter Zijlstra
2016-03-17 23:11         ` Peter Zijlstra
2016-03-18  0:28           ` Paul E. McKenney
2016-03-18  0:17         ` Chris Metcalf
2016-03-18  0:33           ` Paul E. McKenney
2016-03-18  9:40             ` Daniel Thompson
2016-03-18 23:54               ` Paul E. McKenney
2016-03-16 17:02   ` [PATCH v2 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-03-16 17:02   ` [PATCH v2 4/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf
2016-03-16 18:46     ` kbuild test robot
2016-03-21 15:38     ` Peter Zijlstra
2016-03-21 15:46       ` Chris Metcalf
2016-03-21 15:42     ` Peter Zijlstra [this message]
2016-03-21 16:15       ` Chris Metcalf
2016-03-21 16:32         ` Peter Zijlstra
2016-03-21 17:12           ` Chris Metcalf
2016-03-21 17:17             ` Peter Zijlstra
2016-03-21 16:48     ` Peter Zijlstra
2016-03-21 21:49     ` Peter Zijlstra
2016-03-22 17:19       ` [PATCH v3 0/4] improvements to the nmi_backtrace code Chris Metcalf
2016-03-22 17:19         ` [PATCH v3 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-03-22 17:19         ` [PATCH v3 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-03-22 17:19         ` [PATCH v3 4/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf
2016-03-22 17:30           ` Peter Zijlstra
2016-03-22 22:28             ` Rafael J. Wysocki
2016-03-22 22:31           ` Rafael J. Wysocki
2016-03-22 22:45             ` Peter Zijlstra
2016-03-23  0:50               ` Rafael J. Wysocki
2016-03-23  7:53                 ` Peter Zijlstra
2016-03-30 17:16                 ` [PATCH v4 0/4] improvements to the nmi_backtrace code Chris Metcalf
2016-03-30 17:16                   ` [PATCH v4 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Chris Metcalf
2016-03-30 17:16                   ` [PATCH v4 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI Chris Metcalf
2016-03-30 17:16                   ` [PATCH v4 4/4] nmi_backtrace: generate one-line reports for idle cpus Chris Metcalf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160321154201.GA6344@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).