linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] arm64/perf: Changed events naming convention for uniformity
Date: Tue, 22 Mar 2016 09:47:32 +0000	[thread overview]
Message-ID: <20160322094732.GB31126@arm.com> (raw)
In-Reply-To: <1458133309-17045-2-git-send-email-ashoks@broadcom.com>

Hi Ashok,

On Wed, Mar 16, 2016 at 06:01:45AM -0700, Ashok Kumar wrote:
> Changed events name to the format _L1/2/3I/D_CACHE/TLB_.
> For e.g. moved ARMV8_PMUV3_PERFCTR_L1_DCACHE_REFILL to
> ARMV8_PMUV3_PERFCTR_L1D_CACHE_REFILL in line with the already
> existing definitions like ARMV8_PMUV3_PERFCTR_L3D_CACHE_WB.
> 
> Added _ACCESS keyword to some of the definitions
> (ARMV8_PMUV3_PERFCTR_L1D_TLB, ARMV8_PMUV3_PERFCTR_L1I_TLB, etc)
> in line with the already existing definitions like
> ARMV8_PMUV3_PERFCTR_L1_DCACHE_ACCESS for clarity.
> 
> Corrected typo L21 to L2I in ARMV8_PMUV3_PERFCTR_L21_TLB_REFILL,
> ARMV8_PMUV3_PERFCTR_L21_TLB

I don't mind renaming these events, but could we have them matching the
names in the ARM ARM, please? For example:

> -#define ARMV8_PMUV3_PERFCTR_L1D_TLB				0x25
> -#define ARMV8_PMUV3_PERFCTR_L1I_TLB				0x26
> -#define ARMV8_PMUV3_PERFCTR_L2I_CACHE				0x27
> +#define ARMV8_PMUV3_PERFCTR_L1D_TLB_ACCESS			0x25
> +#define ARMV8_PMUV3_PERFCTR_L1I_TLB_ACCESS			0x26
> +#define ARMV8_PMUV3_PERFCTR_L2I_CACHE_ACCESS			0x27

These really are called "L1D_TLB, L1I_TLB and L2I_CACHE" without the
"_ACCESS" suffix.

Will

  reply	other threads:[~2016-03-22  9:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 13:01 [PATCH 0/5] arm64: perf: Broadcom Vulcan PMU support Ashok Kumar
2016-03-16 13:01 ` [PATCH 1/5] arm64/perf: Changed events naming convention for uniformity Ashok Kumar
2016-03-22  9:47   ` Will Deacon [this message]
2016-03-22 15:31     ` Ashok Sekar
2016-03-16 13:01 ` [PATCH 2/5] arm64/perf: Define complete ARMv8 recommended implementation defined events Ashok Kumar
2016-03-16 13:01 ` [PATCH 3/5] arm64/perf: Add Broadcom Vulcan PMU support Ashok Kumar
2016-03-22 10:01   ` Will Deacon
2016-03-22 16:39     ` Ashok Sekar
2016-03-22 16:49       ` Jan Glauber
2016-03-16 13:01 ` [PATCH 4/5] arm64: dts: Add Broadcom Vulcan PMU in dts Ashok Kumar
2016-03-16 13:01 ` [PATCH 5/5] Documentation: arm64: pmu: Add Broadcom Vulcan PMU binding Ashok Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160322094732.GB31126@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).