From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.rutland@arm.com (Mark Rutland) Date: Tue, 22 Mar 2016 10:24:29 +0000 Subject: [PATCH v3 04/11] ARM: bcm2835: dt: add bindings for shared interrupt properties In-Reply-To: <56F10F21.9020709@martin.sperl.org> References: <1457175142-28665-1-git-send-email-kernel@martin.sperl.org> <1457175142-28665-5-git-send-email-kernel@martin.sperl.org> <20160310085714.GA31313@svinekod> <56F10F21.9020709@martin.sperl.org> Message-ID: <20160322102429.GA21158@leverpostej> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Mar 22, 2016 at 10:23:45AM +0100, Martin Sperl wrote: > Hi Mark! Hi Martin, Apologies for having gone silent on this. > On 11.03.2016 09:51, Martin Sperl wrote: > >>On 10.03.2016, at 09:57, Mark Rutland wrote: > >> > >>Alternative options that have been considered: > >>* there is unfortunately no ?interrupt-names? property (like it exists for > >> reg, dma), because then I would have preferred to used: > >> interrupts = <...>, <...>, ?; > >> interrupt-name = ?dma0?, ?dma1?, ..., ?dma10?, ?dmashared?, ?dmaall?; > >> with something like this we could probably have avoided both properties > >> and just added a legacy mapping > >> This would require some changes to the irq framework (which I wanted > >> to avoid) > > I have posted a patch based on this approach (after having found out > that it is possible > with the current framework using platform_get_irq_byname). > > Rob Herring has "Acked" the documentation patch: > [PATCH 1/3] dt/bindings: bcm2835: add interrupt-names property > > Is this approach acceptable for you as well, so that we can try to > get it merged? That approach looks good to me too. One minor nit: please explicitly describe the "dma-shared-all" interrupt-name in the description of interrupt-names. Otherwise, for the binding and the code (which I retains support for existing DTs): Acked-by: Mark Rutland Thanks, Mark.