From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/13] ARM: dts: r8a73a4: Remove unnecessary clock-output-names properties
Date: Wed, 23 Mar 2016 09:52:57 +0900 [thread overview]
Message-ID: <20160323005256.GC5950@verge.net.au> (raw)
In-Reply-To: <CAMuHMdW1D7QSitKPKDLettRmik-NvvfQNLLY-tjXp+ZPHFfdRA@mail.gmail.com>
On Tue, Mar 22, 2016 at 11:17:09AM +0100, Geert Uytterhoeven wrote:
> On Tue, Mar 22, 2016 at 2:40 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > * Fixed rate and fixed factor clocks do not require an
> > clock-output-names property.
> > * Since 07705583e920fef6 ("clk: shmobile: div6: Make clock-output-names
> > optional") Renesas div6 clocks do not require a clock-output-names
> > property.
> >
> > In the above cases there is only one clock output and its name is taken
> > from that of the clock node.
> >
> > Accordingly, remove the unnecessary clock-output-names properties and as
> > necessary update the node names. The zb_clk is excluded from this rename
> > as the MSTP clock driver (clk-mstp.c) explicitly looks for a clock
> > named zb_clk for the r8a73a4 and sh73a0 SoCs.
>
> Yeah, that was a bit hacky, but I didn't see a better solution with the MSTP
> driver. CPG/MSSR would solve that differently.
It made my eyes bleed but I'm over it now :)
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > arch/arm/boot/dts/r8a73a4.dtsi | 76 ++++++++++++++----------------------------
> > 1 file changed, 25 insertions(+), 51 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a73a4.dtsi b/arch/arm/boot/dts/r8a73a4.dtsi
> > index 6583a1dfca1f..6eb23221cf2d 100644
> > --- a/arch/arm/boot/dts/r8a73a4.dtsi
> > +++ b/arch/arm/boot/dts/r8a73a4.dtsi
>
> > @@ -538,173 +533,152 @@
> > clocks = <&pll1_div2_clk>, <0>,
> > <&cpg_clocks R8A73A4_CLK_PLL2S>, <0>;
> > #clock-cells = <0>;
> > - clock-output-names = "zb";
>
> I'm wondering whether we should keep this one for now?
> Dropping it changes the clock name from "zb_clk" to "zb".
>
> Nothing should rely on that, though, but keeping "zb" would allow us to e.g.
> change the MSTP driver to match on clock name instead of node name, and drop
> clock-output-names and rename the clock node later.
Good idea, there seems little point in painting ourselves into a corner.
I'll drop the zb change from this and the sh73a0 patch.
We can clean things up later once/if we have a good plan.
next prev parent reply other threads:[~2016-03-23 0:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 1:40 [PATCH 00/13] ARM, arm64: dts: Remove unnecessary clock-output-names properties Simon Horman
2016-03-22 1:40 ` [PATCH 01/13] ARM: dts: r7s72100: " Simon Horman
2016-03-22 1:40 ` [PATCH 02/13] ARM: dts: r8a73a4: " Simon Horman
2016-03-22 10:17 ` Geert Uytterhoeven
2016-03-23 0:52 ` Simon Horman [this message]
2016-03-22 1:40 ` [PATCH 03/13] ARM: dts: sh73a0: " Simon Horman
2016-03-22 10:17 ` Geert Uytterhoeven
2016-03-22 1:40 ` [PATCH 04/13] ARM: dts: r8a7740: " Simon Horman
2016-03-22 1:40 ` [PATCH 05/13] ARM: dts: r8a7778: " Simon Horman
2016-03-22 1:40 ` [PATCH 06/13] ARM: dts: r8a7779: " Simon Horman
2016-03-22 1:40 ` [PATCH 07/13] ARM: dts: r8a7791: " Simon Horman
2016-03-22 1:40 ` [PATCH 08/13] ARM: dts: r8a7793: " Simon Horman
2016-03-22 1:40 ` [PATCH 09/13] ARM: dts: r8a7794: " Simon Horman
2016-03-22 1:40 ` [PATCH 10/13] ARM: dts: gose: " Simon Horman
2016-03-22 1:40 ` [PATCH 11/13] ARM: dts: koelsch: " Simon Horman
2016-03-22 1:40 ` [PATCH 12/13] ARM: dts: porter: " Simon Horman
2016-03-22 1:40 ` [PATCH 13/13] ARM: dts: lager: " Simon Horman
2016-03-22 10:18 ` [PATCH 00/13] ARM, arm64: dts: " Geert Uytterhoeven
2016-03-23 1:07 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323005256.GC5950@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).