linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: js@sig21.net (Johannes Stezenbach)
To: linux-arm-kernel@lists.infradead.org
Subject: dmaengine pl08x dt crash
Date: Wed, 23 Mar 2016 17:35:17 +0100	[thread overview]
Message-ID: <20160323163517.GA9563@sig21.net> (raw)
In-Reply-To: <20160323162309.GA9472@sig21.net>

On Wed, Mar 23, 2016 at 05:23:09PM +0100, Johannes Stezenbach wrote:
> On Wed, Mar 23, 2016 at 05:12:13PM +0100, Linus Walleij wrote:
> > https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-nomadik.git/log/?h=pl08x-dma
> > 
> > dma: pl08x: support fixed signal assignment

This method of using vendor_data for the fixed_signals flag
doesn't help me much, as my IP is a plain ARM pl081.

I'm also not sure how it would help, since pl08x_of_probe()
is only called for !pl08x->pd (no platform_data) and thus
pl08x_dma_init_virtual_channels() sees 0 channels.
And with platform_data the driver worked fine with fixed channels.

> > dma: pl08x: allocate OF slave channel data at probe time

This looks ore promising, I'm checking it.

> I'll give it a try.  My platform also has fixed channels,
> previously it used platform data but I always thought it is
> ugly, so I tried the new dt support.

Of course I neglected to mention I'm using linux-4.5,
in case you were wondering.


Johannes

  reply	other threads:[~2016-03-23 16:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23 15:40 dmaengine pl08x dt crash Johannes Stezenbach
2016-03-23 16:12 ` Linus Walleij
2016-03-23 16:23   ` Johannes Stezenbach
2016-03-23 16:35     ` Johannes Stezenbach [this message]
2016-03-23 17:26       ` Johannes Stezenbach
2016-03-23 21:42         ` Linus Walleij
2016-03-25 23:34 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160323163517.GA9563@sig21.net \
    --to=js@sig21.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).