From: soren.brinkmann@xilinx.com (Sören Brinkmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/6] Documentation: DT: vdma: update binding doc for AXI CDMA
Date: Sun, 27 Mar 2016 12:27:42 -0700 [thread overview]
Message-ID: <20160327192742.GJ19212@xsjsorenbubuntu> (raw)
In-Reply-To: <1459101966-9932-2-git-send-email-appanad@xilinx.com>
On Sun, 2016-03-27 at 23:36:06 +0530, Kedareswara rao Appana wrote:
> This patch updates the device-tree binding doc for
> adding support for AXI CDMA.
>
> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
> ---
> ---> Modified commit message as suggested by Vinod.
> ---> Moved the patch to forward in the series as suggested by vinod.
>
> .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> index 5841421..2b0c12b 100644
> --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> @@ -8,8 +8,12 @@ target devices. It can be configured to have one channel or two channels.
> If configured as two channels, one is to transmit to the device and another
> is to receive from the device.
>
> +Xilinx AXI CDMA engine, it does transfers between memory-mapped source
> +address and a memory-mapped destination address.
> +
> Required properties:
> -- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
> +- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a" or
> + "xlnx,axi-cdma-1.00.a""
> - #dma-cells: Should be <1>, see "dmas" property below
> - reg: Should contain VDMA registers location and length.
> - xlnx,num-fstores: Should be the number of framebuffers as configured in h/w.
> @@ -80,6 +84,18 @@ axi_dma_0: axidma at 40400000 {
> } ;
> } ;
>
> +axi_cdma_0: axicdma at 7e200000 {
> + compatible = "xlnx,axi-cdma-1.00.a";
> + #dma-cells = <1>;
> + reg = < 0x7e200000 0x10000 >;
> + xlnx,addrwidth = <0x20>;
> + dma-channel at 7e200000 {
> + compatible = "xlnx,axi-dma-mm2s-channel";
> + interrupts = < 0 55 4 >;
> + xlnx,datawidth = <0x40>;
> + } ;
> +} ;
As in the other patch, the node name should be 'dma-controller at ...' and
the inconsistend spacing could be fixed.
Also, it seems this adds pretty much identical examples that just differ
in the compat string. Is that really needed?
S?ren
next prev parent reply other threads:[~2016-03-27 19:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 18:06 [PATCH v2 3/6] Documentation: DT: vdma: update binding doc for AXI DMA Kedareswara rao Appana
2016-03-27 18:06 ` [PATCH v2 5/6] Documentation: DT: vdma: update binding doc for AXI CDMA Kedareswara rao Appana
2016-03-27 19:27 ` Sören Brinkmann [this message]
2016-03-28 5:27 ` Appana Durga Kedareswara Rao
2016-03-28 20:55 ` Rob Herring
2016-03-29 5:48 ` Appana Durga Kedareswara Rao
2016-03-27 19:26 ` [PATCH v2 3/6] Documentation: DT: vdma: update binding doc for AXI DMA Sören Brinkmann
2016-03-28 5:27 ` Appana Durga Kedareswara Rao
2016-03-28 20:52 ` Rob Herring
2016-03-29 5:48 ` Appana Durga Kedareswara Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160327192742.GJ19212@xsjsorenbubuntu \
--to=soren.brinkmann@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox