* [PATCH] ARM: bcm2835: add CPU node for ARM core
@ 2016-03-28 16:21 Stefan Wahren
2016-03-28 19:36 ` Eric Anholt
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Stefan Wahren @ 2016-03-28 16:21 UTC (permalink / raw)
To: linux-arm-kernel
This patch adds the CPU node of the BCM2835 into the DT.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
arch/arm/boot/dts/bcm2835.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
index b83b326..e87aba1 100644
--- a/arch/arm/boot/dts/bcm2835.dtsi
+++ b/arch/arm/boot/dts/bcm2835.dtsi
@@ -3,6 +3,17 @@
/ {
compatible = "brcm,bcm2835";
+ cpus {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ cpu at 0 {
+ device_type = "cpu";
+ compatible = "arm,arm1176jzf-s", "arm,arm1176";
+ reg = <0x0>;
+ };
+ };
+
soc {
ranges = <0x7e000000 0x20000000 0x02000000>;
dma-ranges = <0x40000000 0x00000000 0x20000000>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: bcm2835: add CPU node for ARM core
2016-03-28 16:21 [PATCH] ARM: bcm2835: add CPU node for ARM core Stefan Wahren
@ 2016-03-28 19:36 ` Eric Anholt
2016-03-29 9:41 ` Mark Rutland
2016-03-30 14:17 ` Stephen Warren
2 siblings, 0 replies; 6+ messages in thread
From: Eric Anholt @ 2016-03-28 19:36 UTC (permalink / raw)
To: linux-arm-kernel
Stefan Wahren <stefan.wahren@i2se.com> writes:
> This patch adds the CPU node of the BCM2835 into the DT.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
This looks good to me, but I'll give others a chance to speak up.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160328/608af1f0/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: bcm2835: add CPU node for ARM core
2016-03-28 16:21 [PATCH] ARM: bcm2835: add CPU node for ARM core Stefan Wahren
2016-03-28 19:36 ` Eric Anholt
@ 2016-03-29 9:41 ` Mark Rutland
2016-03-29 10:04 ` Stefan Wahren
2016-03-30 14:17 ` Stephen Warren
2 siblings, 1 reply; 6+ messages in thread
From: Mark Rutland @ 2016-03-29 9:41 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Mar 28, 2016 at 04:21:20PM +0000, Stefan Wahren wrote:
> This patch adds the CPU node of the BCM2835 into the DT.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> arch/arm/boot/dts/bcm2835.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> index b83b326..e87aba1 100644
> --- a/arch/arm/boot/dts/bcm2835.dtsi
> +++ b/arch/arm/boot/dts/bcm2835.dtsi
> @@ -3,6 +3,17 @@
> / {
> compatible = "brcm,bcm2835";
>
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + cpu at 0 {
> + device_type = "cpu";
> + compatible = "arm,arm1176jzf-s", "arm,arm1176";
> + reg = <0x0>;
> + };
> + };
Minor nit: the "arm,arm1176" fallback isn't documented, nor used
elsewhere, so it can/should be dropped.
Otherwise, this looks fine per [1]. With the above change, feel free to
add my ack.
Mark.
[1] Documentation/devicetree/bindings/arm/cpus.txt
> +
> soc {
> ranges = <0x7e000000 0x20000000 0x02000000>;
> dma-ranges = <0x40000000 0x00000000 0x20000000>;
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: bcm2835: add CPU node for ARM core
2016-03-29 9:41 ` Mark Rutland
@ 2016-03-29 10:04 ` Stefan Wahren
2016-03-29 10:13 ` Mark Rutland
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Wahren @ 2016-03-29 10:04 UTC (permalink / raw)
To: linux-arm-kernel
Am 29.03.2016 um 11:41 schrieb Mark Rutland:
> On Mon, Mar 28, 2016 at 04:21:20PM +0000, Stefan Wahren wrote:
>> This patch adds the CPU node of the BCM2835 into the DT.
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> ---
>> arch/arm/boot/dts/bcm2835.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
>> index b83b326..e87aba1 100644
>> --- a/arch/arm/boot/dts/bcm2835.dtsi
>> +++ b/arch/arm/boot/dts/bcm2835.dtsi
>> @@ -3,6 +3,17 @@
>> / {
>> compatible = "brcm,bcm2835";
>>
>> + cpus {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + cpu at 0 {
>> + device_type = "cpu";
>> + compatible = "arm,arm1176jzf-s", "arm,arm1176";
>> + reg = <0x0>;
>> + };
>> + };
> Minor nit: the "arm,arm1176" fallback isn't documented, nor used
> elsewhere, so it can/should be dropped.
This fallback came from arch/arm/boot/dts/s3c64xx.dtsi
I will send a V2 without the fallback.
Stefan
>
> Otherwise, this looks fine per [1]. With the above change, feel free to
> add my ack.
>
> Mark.
>
> [1] Documentation/devicetree/bindings/arm/cpus.txt
>
>> +
>> soc {
>> ranges = <0x7e000000 0x20000000 0x02000000>;
>> dma-ranges = <0x40000000 0x00000000 0x20000000>;
>> --
>> 1.7.9.5
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: bcm2835: add CPU node for ARM core
2016-03-29 10:04 ` Stefan Wahren
@ 2016-03-29 10:13 ` Mark Rutland
0 siblings, 0 replies; 6+ messages in thread
From: Mark Rutland @ 2016-03-29 10:13 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 29, 2016 at 12:04:34PM +0200, Stefan Wahren wrote:
> Am 29.03.2016 um 11:41 schrieb Mark Rutland:
> > On Mon, Mar 28, 2016 at 04:21:20PM +0000, Stefan Wahren wrote:
> >> This patch adds the CPU node of the BCM2835 into the DT.
> >>
> >> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> >> ---
> >> arch/arm/boot/dts/bcm2835.dtsi | 11 +++++++++++
> >> 1 file changed, 11 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> >> index b83b326..e87aba1 100644
> >> --- a/arch/arm/boot/dts/bcm2835.dtsi
> >> +++ b/arch/arm/boot/dts/bcm2835.dtsi
> >> @@ -3,6 +3,17 @@
> >> / {
> >> compatible = "brcm,bcm2835";
> >>
> >> + cpus {
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> +
> >> + cpu at 0 {
> >> + device_type = "cpu";
> >> + compatible = "arm,arm1176jzf-s", "arm,arm1176";
> >> + reg = <0x0>;
> >> + };
> >> + };
> > Minor nit: the "arm,arm1176" fallback isn't documented, nor used
> > elsewhere, so it can/should be dropped.
>
> This fallback came from arch/arm/boot/dts/s3c64xx.dtsi
Ah, indeed. I failed to spot that when grepping. For consistency, we
should probably clean that up.
> I will send a V2 without the fallback.
Cheers!
Mark.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: bcm2835: add CPU node for ARM core
2016-03-28 16:21 [PATCH] ARM: bcm2835: add CPU node for ARM core Stefan Wahren
2016-03-28 19:36 ` Eric Anholt
2016-03-29 9:41 ` Mark Rutland
@ 2016-03-30 14:17 ` Stephen Warren
2 siblings, 0 replies; 6+ messages in thread
From: Stephen Warren @ 2016-03-30 14:17 UTC (permalink / raw)
To: linux-arm-kernel
On 03/28/2016 10:21 AM, Stefan Wahren wrote:
> This patch adds the CPU node of the BCM2835 into the DT.
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-30 14:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-28 16:21 [PATCH] ARM: bcm2835: add CPU node for ARM core Stefan Wahren
2016-03-28 19:36 ` Eric Anholt
2016-03-29 9:41 ` Mark Rutland
2016-03-29 10:04 ` Stefan Wahren
2016-03-29 10:13 ` Mark Rutland
2016-03-30 14:17 ` Stephen Warren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).