public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node
Date: Wed, 30 Mar 2016 12:06:12 +0100	[thread overview]
Message-ID: <20160330110611.GB25354@leverpostej> (raw)
In-Reply-To: <1459290646-3592-3-git-send-email-manabian@gmail.com>

On Wed, Mar 30, 2016 at 12:30:41AM +0200, Joachim Eastwood wrote:
> Add unit name to memory to remove the following warning:
>  Warning (unit_address_vs_reg): Node /memory has a reg or ranges
> 				property, but no unit name

If anything, it would be better to get rid of the memory node from the
skeleton DTs.

For DTs which have a memory node there's no problem, and DTs which
expect a bootlaoder to fill things in have a logical place to document
that fact.

Thanks,
Mark.

> 
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
> ---
>  arch/arm/boot/dts/skeleton.dtsi   | 2 +-
>  arch/arm/boot/dts/skeleton64.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/skeleton.dtsi b/arch/arm/boot/dts/skeleton.dtsi
> index b41d241..a20da0a 100644
> --- a/arch/arm/boot/dts/skeleton.dtsi
> +++ b/arch/arm/boot/dts/skeleton.dtsi
> @@ -9,5 +9,5 @@
>  	#size-cells = <1>;
>  	chosen { };
>  	aliases { };
> -	memory { device_type = "memory"; reg = <0 0>; };
> +	memory at 0 { device_type = "memory"; reg = <0 0>; };
>  };
> diff --git a/arch/arm/boot/dts/skeleton64.dtsi b/arch/arm/boot/dts/skeleton64.dtsi
> index b5d7f36..6dbe9f9 100644
> --- a/arch/arm/boot/dts/skeleton64.dtsi
> +++ b/arch/arm/boot/dts/skeleton64.dtsi
> @@ -9,5 +9,5 @@
>  	#size-cells = <2>;
>  	chosen { };
>  	aliases { };
> -	memory { device_type = "memory"; reg = <0 0 0 0>; };
> +	memory at 0 { device_type = "memory"; reg = <0 0 0 0>; };
>  };
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  parent reply	other threads:[~2016-03-30 11:06 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-29 22:30 [PATCH 0/7] fix unit name warnings on lpc18xx Joachim Eastwood
2016-03-29 22:30 ` [PATCH 1/7] ARM: dts: armv7-m: add unit name to interrupt-controller Joachim Eastwood
2016-04-04  6:05   ` Uwe Kleine-König
2016-04-04  6:42     ` Joachim Eastwood
2016-04-04  6:51       ` Stefan Agner
2016-04-04  7:30       ` Uwe Kleine-König
2016-03-29 22:30 ` [PATCH 2/7] ARM: dts: skeleton: add unit name to memory node Joachim Eastwood
2016-03-30 10:12   ` Vladimir Zapolskiy
2016-03-30 11:06   ` Mark Rutland [this message]
2016-03-30 12:36     ` Joachim Eastwood
2016-03-30 13:06     ` Vladimir Zapolskiy
2016-03-30 13:41       ` Mark Rutland
2016-03-30 16:15         ` Joachim Eastwood
2016-03-30 17:06           ` Mark Rutland
2016-03-30 20:45             ` Joachim Eastwood
2016-03-31 10:38               ` Mark Rutland
2016-03-31 15:21                 ` Joachim Eastwood
2016-03-31 16:34                   ` Joachim Eastwood
2016-04-12 22:45                     ` Rob Herring
2016-04-12 23:03                       ` Joachim Eastwood
2016-03-31 16:27           ` Rob Herring
2016-03-31 16:31             ` Rob Herring
2016-03-31 16:33               ` Joachim Eastwood
2016-03-29 22:30 ` [PATCH 3/7] ARM: dts: lpc18xx: remove unit addresses from creg childs Joachim Eastwood
2016-03-29 22:30 ` [PATCH 4/7] ARM: dts: lpc4357-ea4357: fix unit name warnings from dtc Joachim Eastwood
2016-03-29 22:30 ` [PATCH 5/7] ARM: dts: lpc4350-hitex-eval: " Joachim Eastwood
2016-03-29 22:30 ` [PATCH 6/7] ARM: dts: lpc4337-ciaa:: fix unit name warning " Joachim Eastwood
2016-03-29 22:30 ` [PATCH 7/7] dt-bindings: phy-lpc18xx-usb-otg: remove unit address from binding Joachim Eastwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160330110611.GB25354@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox