linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ynezz@true.cz (Petr Štetiar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity
Date: Wed, 30 Mar 2016 14:06:44 +0200	[thread overview]
Message-ID: <20160330120644.GM20367@ibawizard.net> (raw)
In-Reply-To: <m3h9fuk7ik.fsf@t19.piap.pl>

Krzysztof Ha?asa <khalasa@piap.pl> [2016-03-25 14:32:35]:

Cze??,

> I wonder if all boards (except maybe that Toradex set) use an active-low
> PCIe reset and are now broken. Perhaps Toradex uses active-high and thus
> works.

I'm really puzzled by this :-) With your patch applied I get following on
Toradex Apalis modules:

 DTS:         reset-gpio = <&gpio1 28 GPIO_ACTIVE_LOW>;
 dmesg:       imx6q-pcie 1ffc000.pcie: phy link never came up
 gpio:        gpio-28  (                    |reset               ) out hi
 pin voltage: 0V

 DTS:         reset-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
 dmesg:       ath9k 0000:01:00.0: enabling device (0140 -> 0142)
 gpio:        gpio-28  (                    |reset               ) out lo
 pin voltage: 3V3

So Toradex Apalis is actually active-high? Thanks.

-- ynezz

  parent reply	other threads:[~2016-03-30 12:06 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-25 13:32 [PATCH] i.MX6 PCIe: Fix imx6_pcie_deassert_core_reset() polarity Krzysztof Hałasa
2016-03-27 14:44 ` Fabio Estevam
2016-03-28  0:26   ` Fabio Estevam
2016-03-28 19:59     ` Tim Harvey
2016-03-28 20:13       ` Fabio Estevam
2016-03-28 20:42         ` Tim Harvey
2016-03-28 21:30           ` Fabio Estevam
2016-03-28 22:06             ` Tim Harvey
2016-03-28 22:13               ` Fabio Estevam
2016-03-29  5:40                 ` Krzysztof Hałasa
2016-03-29  5:43                   ` Krzysztof Hałasa
2016-03-29  5:29               ` Krzysztof Hałasa
2016-03-29  8:55               ` Lucas Stach
2016-03-29 10:39                 ` Krzysztof Hałasa
2016-03-29 10:55                   ` Lucas Stach
2016-03-29 13:12                     ` Arnd Bergmann
2016-03-29 13:32                     ` Tim Harvey
2016-03-29 13:52                       ` Arnd Bergmann
2016-03-29 14:29                         ` Tim Harvey
2016-03-29 14:50                           ` Arnd Bergmann
2016-03-29 15:10                             ` Tim Harvey
2016-03-29 15:24                               ` Arnd Bergmann
2016-03-29 17:38                                 ` Tim Harvey
2016-03-29 19:39                                   ` Arnd Bergmann
2016-03-29 17:56                                 ` Marc Zyngier
2016-03-29 16:13                               ` Roberto Fichera
2016-03-29 16:40                                 ` Tim Harvey
2016-03-29 16:44                                   ` Roberto Fichera
2016-03-29 17:31                                     ` Tim Harvey
2016-03-30  8:00                                       ` Roberto Fichera
2016-03-30 10:10                                         ` Arnd Bergmann
2016-03-30 12:50                                           ` Roberto Fichera
2016-03-30 13:38                                             ` Tim Harvey
2016-03-30 15:20                                               ` Roberto Fichera
2016-03-30  8:10                     ` Krzysztof Hałasa
2016-03-31 16:19                       ` Tim Harvey
2016-04-04 10:37                         ` Krzysztof Hałasa
2016-03-29 14:14                 ` Fabio Estevam
2016-03-29  5:21           ` Krzysztof Hałasa
2016-03-30 12:06 ` Petr Štetiar [this message]
2016-03-30 12:45   ` Fabio Estevam
2016-03-30 14:38   ` Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160330120644.GM20367@ibawizard.net \
    --to=ynezz@true.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).