[PATCH v15 17/20] arm64: kdump: implement machine_crash_shutdown()

James Morse
2016-03-31T10:22:39Z

On 31/03/16 08:46, AKASHI Takahiro wrote:
> James Morse wrote:
> > This made me jump: irq_exit() may end up in the __do_softirq() (with irqs turned
> > back on!) ... but these lines are impossible to reach. Maybe get the compiler to
> > enforce this with an unreachable() instead?
>
> I'm not sure how effective unreachable() is here, but OK I will add it.

I thought '__builtin_unreachable()' would generate a warning if it was
reachable, but from [0] it looks like it just suppresses warnings.

You're right, it won't help.

Thanks,

James

[0] https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html