From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: KVM: Add braces to multi-line if statement in virtual PMU code
Date: Fri, 1 Apr 2016 12:36:25 +0100 [thread overview]
Message-ID: <20160401113625.GC3604@arm.com> (raw)
In-Reply-To: <20160401113040.GD20224@cbox>
On Fri, Apr 01, 2016 at 01:30:40PM +0200, Christoffer Dall wrote:
> On Fri, Apr 01, 2016 at 12:12:22PM +0100, Will Deacon wrote:
> > The kernel is written in C, not python, so we need braces around
> > multi-line if statements. GCC 6 actually warns about this, thanks to the
> > fantastic new "-Wmisleading-indentation" flag:
>
> We should rewrite the kernel in python!
Oh man, you made me look and I found this:
https://mail.python.org/pipermail/python-list/2004-October/283327.html
but, today's certainly the day for whacky suggestions.
> > | virt/kvm/arm/pmu.c: In function ?kvm_pmu_overflow_status?:
> > | virt/kvm/arm/pmu.c:198:3: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation]
> > | reg &= vcpu_sys_reg(vcpu, PMCNTENSET_EL0);
> > | ^~~
> > | arch/arm64/kvm/../../../virt/kvm/arm/pmu.c:196:2: note: ...this ?if? clause, but it is not
> > | if ((vcpu_sys_reg(vcpu, PMCR_EL0) & ARMV8_PMU_PMCR_E))
> > | ^~
> >
> > As it turns out, this particular case is harmless (we just do some &=
> > operations with 0), but worth fixing nonetheless.
> >
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
>
> Thanks for the patch.
No problem. I timed it nicely with your pull request.
Will
next prev parent reply other threads:[~2016-04-01 11:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 11:12 [PATCH] arm64: KVM: Add braces to multi-line if statement in virtual PMU code Will Deacon
2016-04-01 11:30 ` Christoffer Dall
2016-04-01 11:36 ` Will Deacon [this message]
2016-04-01 12:10 ` Christoffer Dall
2016-04-01 14:23 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401113625.GC3604@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).