From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 13/16] arm64: dts: add LED nodes for hi6220-hikey
Date: Mon, 4 Apr 2016 00:16:50 -0500 [thread overview]
Message-ID: <20160404051650.GT17806@rob-hp-laptop> (raw)
In-Reply-To: <1459589383-16914-14-git-send-email-guodong.xu@linaro.org>
On Sat, Apr 02, 2016 at 05:29:40PM +0800, Guodong Xu wrote:
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 41 ++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index c4f560a..28bc646 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -63,6 +63,47 @@
> status = "ok";
> };
> };
> +
> + leds {
> + compatible = "gpio-leds";
> + user_led4 {
Don't use underscores in node names: user-led4
> + label = "user_led4";
We need to make sure the node names and labels are aligned with other
boards. There's some discussion about this for the new db600 board.
This looks closer to what we should have than what we have for
db410c currently.
Rob
next prev parent reply other threads:[~2016-04-04 5:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 9:29 [PATCH v2 00/16] DTS for hi6220 and HiKey Guodong Xu
2016-04-02 9:29 ` [PATCH v2 01/16] arm64: dts: Reserve memory regions for hi6220 Guodong Xu
2016-04-02 9:29 ` [PATCH v2 02/16] arm64: dts: add sp804 timer node for Hi6220 Guodong Xu
2016-04-03 19:23 ` Linus Walleij
2016-04-04 1:43 ` Leo Yan
2016-04-04 11:21 ` Linus Walleij
2016-04-04 13:42 ` Leo Yan
2016-04-04 13:53 ` Linus Walleij
2016-04-04 14:03 ` Leo Yan
2016-04-04 5:16 ` Rob Herring
2016-04-02 9:29 ` [PATCH v2 03/16] arm64: dts: enable idle states " Guodong Xu
2016-04-02 9:29 ` [PATCH v2 04/16] arm64: dts: Add Hi6220 gpio configuration nodes Guodong Xu
2016-04-03 19:28 ` Linus Walleij
2016-04-12 9:18 ` Guodong Xu
2016-04-02 9:29 ` [PATCH v2 05/16] arm64: dts: add Hi6220 pinctrl " Guodong Xu
2016-04-03 19:31 ` Linus Walleij
2016-04-04 22:54 ` Tony Lindgren
2016-04-02 9:29 ` [PATCH v2 06/16] arm64: dts: add Hi6220 spi " Guodong Xu
2016-04-04 5:16 ` Rob Herring
2016-04-12 9:40 ` Guodong Xu
2016-04-02 9:29 ` [PATCH v2 07/16] arm64: dts: add all hi6220 i2c nodes Guodong Xu
2016-04-02 9:29 ` [PATCH v2 08/16] arm64: dts: hikey: enable i2c0 and i2c1 for working with mezzanine boards Guodong Xu
2016-04-04 5:16 ` Rob Herring
2016-04-02 9:29 ` [PATCH v2 09/16] arm64: dts: add hi6220 usb node Guodong Xu
2016-04-02 9:29 ` [PATCH v2 10/16] arm64: dts: add mailbox node for Hi6220 Guodong Xu
2016-04-02 9:29 ` [PATCH v2 11/16] arm64: dts: add Hi6220's stub clock node Guodong Xu
2016-04-02 9:29 ` [PATCH v2 12/16] arm64: dts: hi6220: add pinctrl for uarts and enable them Guodong Xu
2016-04-02 9:29 ` [PATCH v2 13/16] arm64: dts: add LED nodes for hi6220-hikey Guodong Xu
2016-04-04 5:16 ` Rob Herring [this message]
2016-04-02 9:29 ` [PATCH v2 14/16] arm64: dts: hikey: Add hi655x pmic dts node Guodong Xu
2016-04-04 5:16 ` Rob Herring
2016-04-12 13:14 ` Guodong Xu
2016-04-02 9:29 ` [PATCH v2 15/16] arm64: dts: add dwmmc nodes for hi6220 Guodong Xu
2016-04-02 9:29 ` [PATCH v2 16/16] arm64: dts: add wifi nodes support for hi6220-hikey Guodong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160404051650.GT17806@rob-hp-laptop \
--to=robh@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox