linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] ARM: l2x0: add three special L210 aux control flags
Date: Tue, 5 Apr 2016 09:08:27 +0100	[thread overview]
Message-ID: <20160405080827.GA19428@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20160404233640.GW19428@n2100.arm.linux.org.uk>

On Tue, Apr 05, 2016 at 12:36:40AM +0100, Russell King - ARM Linux wrote:
> On Mon, Apr 04, 2016 at 06:29:26PM -0500, Josh Cartwright wrote:
> > Similarly, we're waiting on feedback for:
> > 
> >   http://lkml.kernel.org/r/1456761716-10174-1-git-send-email-brad.mouring at ni.com
> > 
> > Also in the queue; also w/ Rob's Ack.  There was a change awhile back to
> > unconditionally enable the power-management features of the PL310 which
> > caused a noticeable performance degradation on our boards; placing the
> > PM options behind a togglable DT property provides us an out.
> 
> For that one, I've been wondering why it's seemingly acceptable to
> start throwing *errors* for *new* DT properties which weren't required
> before.  Also, there's no DT documentation for the new properties,
> which is a fundamental requirement - and Rob should not have given
> his ack without there being a DT documentation patch.
> 
> Obviously, the kernel review process has broken on this one... or
> I must remember this sneaky trick for getting new DT properties in
> without the required documentation...

There's another issue here - we go from enabling these options by
default to leaving them as the firmware specified them.  While that's
something I approve of, I'm not happy because it means all platforms
that have these PM bits enabled today could end up losing them - so
it's a PM regression waiting to happen.  Who's going to add them to
all the dt blobs where platforms _can_ cope with having these PM bits
enabled?

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2016-04-05  8:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15 12:11 [PATCH RESEND] ARM: l2x0: add three special L210 aux control flags Linus Walleij
2016-03-18 21:10 ` Rob Herring
2016-04-03 16:22 ` Linus Walleij
2016-04-04 23:29   ` Josh Cartwright
2016-04-04 23:36     ` Russell King - ARM Linux
2016-04-05  8:08       ` Russell King - ARM Linux [this message]
2016-04-05 13:12         ` Josh Cartwright
2016-04-05 14:05           ` Brad Mouring
2016-04-05 12:35       ` Josh Cartwright
2016-04-05  7:43   ` Russell King - ARM Linux
2016-04-05  7:57     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160405080827.GA19428@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).