Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: iamjoonsoo.kim@lge.com (Joonsoo Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: next-20160401+: ARM: DRA7: linux-next regression: mm/slab: clean-up kmem_cache_node setup
Date: Mon, 11 Apr 2016 11:02:03 +0900	[thread overview]
Message-ID: <20160411020203.GA25211@js1304-P5Q-DELUXE> (raw)
In-Reply-To: <570816F8.9070301@ti.com>

On Fri, Apr 08, 2016 at 03:39:20PM -0500, Nishanth Menon wrote:
> Hi,
> 
> http://marc.info/?l=linux-omap&m=146014314115625&w=2 series works with
> v4.6-rc2 kernel, however, it fails with linux-next for suspend-to-ram
> (mem) on BeagleBoard-X15
> 
> next-20160327 - good
> next-20160329 - good
> next-20160330 - Fails to boot - I2C crashes
> next-20160331-  Fails to boot - USB crashes
> next-20160401 -> bad
> next-20160408 -> bad
> 
> Bisect log of next-20160408 vs v4.6-rc2 ->
> http://pastebin.ubuntu.com/15697856/
> 
> # first bad commit: [2b629704a2b6a5b239f23750e5517a9d8c3a4e8c]
> mm/slab: clean-up kmem_cache_node setup
> 

Hello,

I made a mistake on that patch. Could you try to test below one on
top of it.

Thanks.

--------->8----------------
>From d3af3cc409527e9be6beb62ea395cde67f3c5029 Mon Sep 17 00:00:00 2001
From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Date: Mon, 11 Apr 2016 10:48:29 +0900
Subject: [PATCH] mm/slab: clean-up kmem_cache_node setup-fix

After calling free_block(), we need to re-calculate array_cache's
avail counter. Fix it.

And, it's better to free objects in shared array when it is
really necessary. Check it before calling free_block().

Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
---
 mm/slab.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/slab.c b/mm/slab.c
index fcd5fbb..27cb390 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -927,9 +927,10 @@ static int setup_kmem_cache_node(struct kmem_cache *cachep,
 
 	n = get_node(cachep, node);
 	spin_lock_irq(&n->list_lock);
-	if (n->shared) {
+	if (n->shared && force_change) {
 		free_block(cachep, n->shared->entry,
 				n->shared->avail, node, &list);
+		n->shared->avail = 0;
 	}
 
 	if (!n->shared || force_change) {
-- 
1.9.1

  reply	other threads:[~2016-04-11  2:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 20:39 next-20160401+: ARM: DRA7: linux-next regression: mm/slab: clean-up kmem_cache_node setup Nishanth Menon
2016-04-11  2:02 ` Joonsoo Kim [this message]
2016-04-11 11:44   ` Jon Hunter
2016-04-20  7:11     ` Jon Hunter
2016-04-20  7:49       ` Joonsoo Kim
2016-04-20 23:31         ` Stephen Rothwell
2016-04-11 13:15   ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160411020203.GA25211@js1304-P5Q-DELUXE \
    --to=iamjoonsoo.kim@lge.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox