linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx6q-tbs2910: fix fec reset polarity
@ 2016-04-05 14:55 Soeren Moch
  2016-04-12  7:39 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Soeren Moch @ 2016-04-05 14:55 UTC (permalink / raw)
  To: linux-arm-kernel

According to Documentation/devicetree/bindings/net/fsl-fec.txt the polarity
of "phy-reset-gpios" is assumed to be active-low unless a separate property
"phy-reset-active-high" is available. So replace the inconsistent polarity
description to make the correct active-low reset behavior more obvious.

Signed-off-by: Soeren Moch <smoch@web.de>
---
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: linux-arm-kernel at lists.infradead.org
---
 arch/arm/boot/dts/imx6q-tbs2910.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6q-tbs2910.dts b/arch/arm/boot/dts/imx6q-tbs2910.dts
index 0da81bc..2401c6b 100644
--- a/arch/arm/boot/dts/imx6q-tbs2910.dts
+++ b/arch/arm/boot/dts/imx6q-tbs2910.dts
@@ -141,7 +141,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
 	phy-mode = "rgmii";
-	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_HIGH>;
+	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: dts: imx6q-tbs2910: fix fec reset polarity
  2016-04-05 14:55 [PATCH] ARM: dts: imx6q-tbs2910: fix fec reset polarity Soeren Moch
@ 2016-04-12  7:39 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2016-04-12  7:39 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Apr 05, 2016 at 04:55:04PM +0200, Soeren Moch wrote:
> According to Documentation/devicetree/bindings/net/fsl-fec.txt the polarity
> of "phy-reset-gpios" is assumed to be active-low unless a separate property
> "phy-reset-active-high" is available. So replace the inconsistent polarity
> description to make the correct active-low reset behavior more obvious.
> 
> Signed-off-by: Soeren Moch <smoch@web.de>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-04-12  7:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-05 14:55 [PATCH] ARM: dts: imx6q-tbs2910: fix fec reset polarity Soeren Moch
2016-04-12  7:39 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).