* [PATCH] ARM: uniphier: drop weird sizeof()
@ 2016-03-25 2:14 Masahiro Yamada
2016-04-12 19:06 ` Olof Johansson
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2016-03-25 2:14 UTC (permalink / raw)
To: linux-arm-kernel
My intention was to ioremap a 4-byte register. Coincidentally enough,
sizeof(SZ_4) equals to SZ_4, but this code is weird anyway.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/arm/mach-uniphier/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-uniphier/platsmp.c b/arch/arm/mach-uniphier/platsmp.c
index 6914135..db04142 100644
--- a/arch/arm/mach-uniphier/platsmp.c
+++ b/arch/arm/mach-uniphier/platsmp.c
@@ -120,7 +120,7 @@ static int __init uniphier_smp_prepare_trampoline(unsigned int max_cpus)
if (ret)
return ret;
- uniphier_smp_rom_boot_rsv2 = ioremap(rom_rsv2_phys, sizeof(SZ_4));
+ uniphier_smp_rom_boot_rsv2 = ioremap(rom_rsv2_phys, SZ_4);
if (!uniphier_smp_rom_boot_rsv2) {
pr_err("failed to map ROM_BOOT_RSV2 register\n");
return -ENOMEM;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: uniphier: drop weird sizeof()
2016-03-25 2:14 [PATCH] ARM: uniphier: drop weird sizeof() Masahiro Yamada
@ 2016-04-12 19:06 ` Olof Johansson
0 siblings, 0 replies; 2+ messages in thread
From: Olof Johansson @ 2016-04-12 19:06 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Mar 25, 2016 at 11:14:02AM +0900, Masahiro Yamada wrote:
> My intention was to ioremap a 4-byte register. Coincidentally enough,
> sizeof(SZ_4) equals to SZ_4, but this code is weird anyway.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
Applied to fixes, thanks.
-Olof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-12 19:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-25 2:14 [PATCH] ARM: uniphier: drop weird sizeof() Masahiro Yamada
2016-04-12 19:06 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).