From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
Date: Tue, 12 Apr 2016 12:11:49 -0700 [thread overview]
Message-ID: <20160412191149.GC4174@localhost> (raw)
In-Reply-To: <1459245786-11905-1-git-send-email-suzuki.poulose@arm.com>
On Tue, Mar 29, 2016 at 11:03:06AM +0100, Suzuki K Poulose wrote:
> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
> added support for ARCH_SUNXI on arm64, but failed to select
> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
> and causes build failures like :
>
> UPD include/generated/compile.h
> CC init/version.o
> LD init/built-in.o
> drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
> drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_alt_chip'
> drivers/built-in.o: In function `irq_domain_add_linear':
> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
> drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
> drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_domain_generic_chips'
> drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_domain_generic_chip'
> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
> drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_set_bit'
> drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_set_bit'
> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
>
> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
> Cc: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
It'd be nice to have a silent Kconfig entry that selects from ARCH_SUNXI that
sets this dependency, instead of having it from the architecture code. This
pushes down the dependency to the right level.
Can you respin with it like that instead?
-Olof
next prev parent reply other threads:[~2016-04-12 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 10:03 [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip Suzuki K Poulose
2016-04-06 9:05 ` Andre Przywara
2016-04-07 14:18 ` Suzuki K Poulose
2016-04-12 19:11 ` Olof Johansson [this message]
2016-04-13 9:05 ` Suzuki K Poulose
2016-04-13 13:17 ` Rob Herring
2016-04-13 13:20 ` Suzuki K Poulose
-- strict thread matches above, loose matches on Subject: below --
2016-05-09 22:37 Andre Przywara
2016-05-10 19:10 ` Maxime Ripard
2016-05-10 19:44 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412191149.GC4174@localhost \
--to=olof@lixom.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).