From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) Date: Wed, 13 Apr 2016 16:32:49 +0200 Subject: [PATCH v4 3/5] clk: mvebu: new driver for Armada AP806 system controller In-Reply-To: <20160402012731.GE18567@codeaurora.org> References: <1459070777-18049-1-git-send-email-thomas.petazzoni@free-electrons.com> <1459070777-18049-4-git-send-email-thomas.petazzoni@free-electrons.com> <20160402012731.GE18567@codeaurora.org> Message-ID: <20160413163249.157e3a77@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, On Fri, 1 Apr 2016 18:27:31 -0700, Stephen Boyd wrote: > > +#include > > +#include > > Is this used? No, fixed! > > +#include > > +#include > > Is this used? Ditto! > > +static void __init ap806_syscon_clk_init(struct device_node *np) > > Can this be a platform driver instead? I've moved to a platform driver, and it seems to work fine. Will be in v5. Thanks for the review! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com