From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] regulator: rk808: Make rk808 generic, rename rk808-regulator.c
Date: Fri, 15 Apr 2016 18:24:06 +0200 [thread overview]
Message-ID: <20160415162406.GD25196@piout.net> (raw)
In-Reply-To: <20160415102602.GE3217@sirena.org.uk>
On 15/04/2016 at 11:26:02 +0100, Mark Brown wrote :
> On Fri, Apr 15, 2016 at 11:16:27AM +0200, Wadim Egorov wrote:
>
> > This patch just renames the rk808 driver so we can reuse this driver
> > to add more regulator devices from the RK8XX PMIC family later.
>
> We normally manage to cope fine without renaming things - it's quite
> common to have drivers that were initially named after one part
> supporting multiple parts, avoiding the rename makes things like
> backports easier and avoids needing git log --follow and so on.
I agree with that and I will also add that probably at some point in
time a new part may appear with a name matching rk8xx but may not be
compatible with the rk8xx driver and that is when the real mess starts.
Finally, renaming the config options and the modules is not nice for the
user.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-15 16:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 9:16 [PATCH 0/6] Add RK818 PMIC support Wadim Egorov
2016-04-15 9:16 ` [PATCH 1/6] mfd: RK808: Make RK808 generic, rename rk808.c to rk8xx.c Wadim Egorov
2016-04-15 9:16 ` [PATCH 2/6] mfd: RK808: Add RK818 support Wadim Egorov
2016-04-15 9:16 ` [PATCH 3/6] regulator: rk808: Make rk808 generic, rename rk808-regulator.c Wadim Egorov
2016-04-15 10:26 ` Mark Brown
2016-04-15 16:24 ` Alexandre Belloni [this message]
2016-04-18 7:25 ` Wadim Egorov
2016-04-18 17:03 ` Mark Brown
2016-04-15 10:36 ` [PATCH] regulator: rk808: fix platform_no_drv_owner.cocci warnings kbuild test robot
2016-04-15 10:36 ` [PATCH 3/6] regulator: rk808: Make rk808 generic, rename rk808-regulator.c kbuild test robot
2016-04-15 9:16 ` [PATCH 4/6] regulator: rk8xx: Migrate to regulator core's simplified DT parsing code Wadim Egorov
2016-04-15 9:16 ` [PATCH 5/6] regulator: rk8xx: Add regulator driver for RK818 Wadim Egorov
2016-04-15 9:16 ` [PATCH 6/6] mfd: dt-bindings: Add RK818 device tree bindings document Wadim Egorov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415162406.GD25196@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).