linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 31/47] ARM: dts: r8a7794: Reference both DMA controllers in SCIFA nodes
Date: Mon, 18 Apr 2016 13:40:59 +1000	[thread overview]
Message-ID: <20160418034059.GA1966@verge.net.au> (raw)
In-Reply-To: <CAMuHMdUUz-0EhgogpHGV-yE6htbwvAjuoAm2+DtDLa3xiG1XkA@mail.gmail.com>

On Wed, Apr 13, 2016 at 09:55:14PM +0200, Geert Uytterhoeven wrote:
> Hi Olof,
> 
> On Wed, Apr 13, 2016 at 9:48 PM, Olof Johansson <olof@lixom.net> wrote:
> > On Sun, Apr 3, 2016 at 6:23 PM, Simon Horman <horms+renesas@verge.net.au> wrote:
> >> diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi
> >> index eacb2b291361..4256557ca041 100644
> >> --- a/arch/arm/boot/dts/r8a7794.dtsi
> >> +++ b/arch/arm/boot/dts/r8a7794.dtsi
> >> @@ -296,8 +296,9 @@
> >>                 interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
> >>                 clocks = <&mstp2_clks R8A7794_CLK_SCIFA0>;
> >>                 clock-names = "fck";
> >> -               dmas = <&dmac0 0x21>, <&dmac0 0x22>;
> >> -               dma-names = "tx", "rx";
> >> +               dmas = <&dmac0 0x21>, <&dmac0 0x22>,
> >> +                      <&dmac1 0x21>, <&dmac1 0x22>;
> >> +               dma-names = "tx", "rx", "tx", "rx";
> >>                 power-domains = <&cpg_clocks>;
> >>                 status = "disabled";
> >>         };
> >
> > The names are no longer unique. So a get_<foo>_by_name() function no
> > longer can work as expected.
> 
> That's intentional, and a relic of how dma_request_slave_channel_compat()
> works: if e.g. the first "tx" channel can't be gotten (e.g. because
> the referenced
> DMAC instance ran out of channels), it will try the next one.

Hi Olof,

is the above acceptable to you?

  reply	other threads:[~2016-04-18  3:40 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04  1:23 [GIT PULL] Renesas ARM Based SoC DT Updates for v4.7 Simon Horman
2016-04-04  1:22 ` [PATCH 01/47] ARM: dts: r8a7790: use fallback jpu compatibility string Simon Horman
2016-04-04  1:22 ` [PATCH 02/47] ARM: dts: r8a7791: " Simon Horman
2016-04-04  1:22 ` [PATCH 03/47] ARM: dts: r8a7790: Add SCIF2 clock Simon Horman
2016-04-04  1:22 ` [PATCH 04/47] ARM: dts: r8a7790: Add SCIF2 device node Simon Horman
2016-04-04  1:22 ` [PATCH 05/47] ARM: dts: r8a7791: use fallback can compatibility string Simon Horman
2016-04-04  1:22 ` [PATCH 06/47] ARM: dts: r8a7790: " Simon Horman
2016-04-04  1:22 ` [PATCH 07/47] ARM: dts: r8a7790: Reference both DMA controllers in SCIFA nodes Simon Horman
2016-04-04  1:22 ` [PATCH 08/47] ARM: dts: r8a7790: Reference both DMA controllers in SCIFB nodes Simon Horman
2016-04-04  1:22 ` [PATCH 09/47] ARM: dts: r8a7790: Reference both DMA controllers in HSCIF nodes Simon Horman
2016-04-04  1:22 ` [PATCH 10/47] ARM: dts: r8a7790: Reference both DMA controllers in SCIF nodes Simon Horman
2016-04-04  1:22 ` [PATCH 11/47] ARM: dts: r8a7790: Reference both DMA controllers in MSIOF nodes Simon Horman
2016-04-04  1:22 ` [PATCH 12/47] ARM: dts: r8a7790: Reference both DMA controllers in QSPI node Simon Horman
2016-04-04  1:22 ` [PATCH 13/47] ARM: dts: r8a7790: Reference both DMA controllers in IIC nodes Simon Horman
2016-04-04  1:22 ` [PATCH 14/47] ARM: dts: r8a7790: Reference both DMA controllers in SDHI nodes Simon Horman
2016-04-04  1:22 ` [PATCH 15/47] ARM: dts: r8a7790: Reference both DMA controllers in MMCIF nodes Simon Horman
2016-04-04  1:22 ` [PATCH 16/47] ARM: dts: r8a7791: Reference both DMA controllers in SCIFA nodes Simon Horman
2016-04-04  1:22 ` [PATCH 17/47] ARM: dts: r8a7791: Reference both DMA controllers in SCIFB nodes Simon Horman
2016-04-04  1:22 ` [PATCH 18/47] ARM: dts: r8a7791: Reference both DMA controllers in HSCIF nodes Simon Horman
2016-04-04  1:22 ` [PATCH 19/47] ARM: dts: r8a7791: Reference both DMA controllers in SCIF nodes Simon Horman
2016-04-04  1:22 ` [PATCH 20/47] ARM: dts: r8a7791: Reference both DMA controllers in MSIOF nodes Simon Horman
2016-04-04  1:22 ` [PATCH 21/47] ARM: dts: r8a7791: Reference both DMA controllers in QSPI node Simon Horman
2016-04-04  1:22 ` [PATCH 22/47] ARM: dts: r8a7791: Reference both DMA controllers in IIC nodes Simon Horman
2016-04-04  1:22 ` [PATCH 23/47] ARM: dts: r8a7791: Reference both DMA controllers in SDHI nodes Simon Horman
2016-04-04  1:22 ` [PATCH 24/47] ARM: dts: r8a7791: Reference both DMA controllers in MMCIF node Simon Horman
2016-04-04  1:22 ` [PATCH 25/47] ARM: dts: r8a7793: Reference both DMA controllers in SCIFA nodes Simon Horman
2016-04-04  1:22 ` [PATCH 26/47] ARM: dts: r8a7793: Reference both DMA controllers in SCIFB nodes Simon Horman
2016-04-04  1:22 ` [PATCH 27/47] ARM: dts: r8a7793: Reference both DMA controllers in HSCIF nodes Simon Horman
2016-04-04  1:23 ` [PATCH 28/47] ARM: dts: r8a7793: Reference both DMA controllers in SCIF nodes Simon Horman
2016-04-04  1:23 ` [PATCH 29/47] ARM: dts: r8a7793: Reference both DMA controllers in QSPI node Simon Horman
2016-04-04  1:23 ` [PATCH 30/47] ARM: dts: r8a7793: Reference both DMA controllers in IIC nodes Simon Horman
2016-04-04  1:23 ` [PATCH 31/47] ARM: dts: r8a7794: Reference both DMA controllers in SCIFA nodes Simon Horman
2016-04-13 19:48   ` Olof Johansson
2016-04-13 19:55     ` Geert Uytterhoeven
2016-04-18  3:40       ` Simon Horman [this message]
2016-04-19 23:01         ` Simon Horman
2016-04-21  9:43         ` Niklas Söderlund
2016-04-26 13:43       ` Niklas Söderlund
2016-04-04  1:23 ` [PATCH 32/47] ARM: dts: r8a7794: Reference both DMA controllers in SCIFB nodes Simon Horman
2016-04-04  1:23 ` [PATCH 33/47] ARM: dts: r8a7794: Reference both DMA controllers in HSCIF nodes Simon Horman
2016-04-04  1:23 ` [PATCH 34/47] ARM: dts: r8a7794: Reference both DMA controllers in SCIF nodes Simon Horman
2016-04-04  1:23 ` [PATCH 35/47] ARM: dts: r8a7794: Reference both DMA controllers in QSPI node Simon Horman
2016-04-04  1:23 ` [PATCH 36/47] ARM: dts: r8a7794: Reference both DMA controllers in SDHI nodes Simon Horman
2016-04-04  1:23 ` [PATCH 37/47] ARM: dts: r8a7794: Reference both DMA controllers in MMCIF node Simon Horman
2016-04-04  1:23 ` [PATCH 38/47] ARM: dts: r8a7794: add CAN clocks to device tree Simon Horman
2016-04-04  1:23 ` [PATCH 39/47] ARM: dts: r8a7794: add CAN nodes " Simon Horman
2016-04-04  1:23 ` [PATCH 40/47] ARM: dts: r8a7793: add CAN clocks " Simon Horman
2016-04-04  1:23 ` [PATCH 41/47] ARM: dts: r8a7793: add CAN nodes " Simon Horman
2016-04-04  1:23 ` [PATCH 42/47] ARM: dts: r8a7794: add IIC clocks Simon Horman
2016-04-04  1:23 ` [PATCH 43/47] ARM: dts: r8a7794: Add IIC nodes Simon Horman
2016-04-04  1:23 ` [PATCH 44/47] ARM: dts: sh73a0: Correct interrupt type for ARM TWD Simon Horman
2016-04-04  1:23 ` [PATCH 45/47] ARM: dts: r8a7779: " Simon Horman
2016-04-04  1:23 ` [PATCH 46/47] ARM: dts: r8a7790: Use USB3.0 fallback compatibility string Simon Horman
2016-04-04  1:23 ` [PATCH 47/47] ARM: dts: r8a7791: " Simon Horman
2016-04-13 19:48 ` [GIT PULL] Renesas ARM Based SoC DT Updates for v4.7 Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160418034059.GA1966@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).