From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx25-pinfunc: remove SION from all modes
Date: Wed, 20 Apr 2016 10:58:39 +0200 [thread overview]
Message-ID: <20160420085839.GI29108@pengutronix.de> (raw)
In-Reply-To: <20160420104617.15cf8461@ipc1.ka-ro>
On Wed, Apr 20, 2016 at 10:46:17AM +0200, Lothar Wa?mann wrote:
> Hi,
>
> On Tue, 19 Apr 2016 22:19:58 +0100 Russell King - ARM Linux wrote:
> > On Tue, Apr 19, 2016 at 09:45:14PM +0200, Uwe Kleine-K?nig wrote:
> > > With the SION bit set a pin can be read as GPIO even though it's not muxed
> > > as GPIO. This is useful at times. The downside however is that the signal
> > > is not only routed to the GPIO IP but also all other IPs that can make use
> > > of the pin. This resulted in more than one issue for me in the past. Things
> > > like spi transfers that result in usb reenumeration or setting a GPIO to a
> > > value that triggers an RTS irq for an UART.
> >
> > Isn't SION required for all GPIOs such that reading the value of a GPIO
> > pin returns the actual state of the pin, not the output value written
> > to it?
> >
> > What about the ethernet pins? I know that on iMX6, SION is required for
> > correct functionality of certain phy clocking modes, and I wouldn't be
> > surprised if this was true in earlier designs as well.
> >
> SION essentially makes any OUTPUT pin (GPIO or other function)
> bidirectional.
Yes, and the bad thing is that the input is routed to all modules that
the pin can be muxed for. So if on i.MX25 you intend to set the value of
gpio 3.21 you also toggle UART5's RTS signal with SION set.
And note that SION also has an effect on input pins (i.e. it is routed
to all modules instead of only the muxed one).
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2016-04-20 8:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 19:45 [PATCH] ARM: imx25-pinfunc: remove SION from all modes Uwe Kleine-König
2016-04-19 21:19 ` Russell King - ARM Linux
2016-04-20 7:51 ` Uwe Kleine-König
2016-04-20 8:46 ` Lothar Waßmann
2016-04-20 8:58 ` Uwe Kleine-König [this message]
2016-06-03 13:32 ` Uwe Kleine-König
2016-06-03 14:01 ` Shawn Guo
2016-06-03 19:31 ` Uwe Kleine-König
2016-06-13 10:16 ` Uwe Kleine-König
2016-06-13 10:17 ` [PATCH 1/2] ARM: imx25-pinfunc: document SION being important for MX25_PAD_SD1_CMD__SD1_CMD Uwe Kleine-König
2016-06-13 10:17 ` [PATCH 2/2] ARM: imx25-pinfunc: remove SION from all modes Uwe Kleine-König
2016-06-16 0:32 ` [PATCH] " Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420085839.GI29108@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).