From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/8] cpufreq: imx: Use generic platdev driver
Date: Thu, 21 Apr 2016 15:20:32 +0530 [thread overview]
Message-ID: <20160421095032.GD29799@vireshk-i7> (raw)
In-Reply-To: <18756925.NSB5aJaqC9@wuerfel>
On 21-04-16, 11:46, Arnd Bergmann wrote:
> On Thursday 21 April 2016 14:13:48 Viresh Kumar wrote:
> > The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform
> > device now, reuse that and remove similar code from platform code.
> >
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: Sascha Hauer <kernel@pengutronix.de>
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> > arch/arm/mach-imx/imx27-dt.c | 4 ----
> > arch/arm/mach-imx/mach-imx51.c | 3 ---
> > arch/arm/mach-imx/mach-imx53.c | 2 --
> > arch/arm/mach-imx/mach-imx7d.c | 6 ------
> > drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++
> > 5 files changed, 5 insertions(+), 15 deletions(-)
> >
> > diff --git a/arch/arm/mach-imx/imx27-dt.c b/arch/arm/mach-imx/imx27-dt.c
> > index bd42d1bd10af..90c62bf01f9e 100644
> > --- a/arch/arm/mach-imx/imx27-dt.c
> > +++ b/arch/arm/mach-imx/imx27-dt.c
> > @@ -20,11 +20,7 @@
> >
> > static void __init imx27_dt_init(void)
> > {
> > - struct platform_device_info devinfo = { .name = "cpufreq-dt", };
> > -
> > of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> > -
> > - platform_device_register_full(&devinfo);
> > }
> >
>
> Please remove the entire function now, a NULL .init_machine machine
> callback pointer has the same effect as the remaining line.
>
> The rest of the patch is fine.
Perhaps that should be done in a separate patch I feel. Will do so after this is
merged.
--
viresh
next prev parent reply other threads:[~2016-04-21 9:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1461228081.git.viresh.kumar@linaro.org>
2016-04-21 8:43 ` [PATCH 1/8] cpufreq: berlin: Use generic platdev driver Viresh Kumar
2016-04-21 9:05 ` Antoine Tenart
2016-04-21 8:43 ` [PATCH 2/8] cpufreq: imx: " Viresh Kumar
2016-04-21 9:19 ` Lucas Stach
2016-04-21 9:46 ` Arnd Bergmann
2016-04-21 9:50 ` Viresh Kumar [this message]
2016-04-21 10:17 ` Arnd Bergmann
2016-04-21 8:43 ` [PATCH 3/8] cpufreq: omap: " Viresh Kumar
2016-04-21 8:43 ` [PATCH 4/8] cpufreq: rockchip: " Viresh Kumar
2016-04-21 8:43 ` [PATCH 5/8] cpufreq: shmobile: " Viresh Kumar
2016-04-21 13:04 ` Geert Uytterhoeven
2016-04-22 3:21 ` Viresh Kumar
2016-04-22 6:41 ` Geert Uytterhoeven
2016-04-22 6:47 ` Viresh Kumar
2016-04-21 8:43 ` [PATCH 6/8] cpufreq: sunxi: " Viresh Kumar
2016-04-21 8:54 ` Maxime Ripard
2016-04-21 8:43 ` [PATCH 7/8] cpufreq: zynq: " Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421095032.GD29799@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox