* [PATCH] ARM: dts: imx53-qsb: Fix regulator constraints
@ 2016-04-19 18:15 Fabio Estevam
2016-04-26 3:19 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2016-04-19 18:15 UTC (permalink / raw)
To: linux-arm-kernel
Currently the imx53-qsb board with a Dialog DA9053 PMIC fails to boot:
[ 0.397546] LDO3: Bringing 3300000uV into 1800000-1800000uV
The LDO3 voltage constraints passed in the device tree do not match
the valid range according to the datasheet, so fix this accordingly to
allow the board booting again.
While at that, fix the other voltage constraints as well.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
arch/arm/boot/dts/imx53-qsb.dts | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
index dec4b07..3799396 100644
--- a/arch/arm/boot/dts/imx53-qsb.dts
+++ b/arch/arm/boot/dts/imx53-qsb.dts
@@ -64,8 +64,8 @@
};
ldo3_reg: ldo3 {
- regulator-min-microvolt = <600000>;
- regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <1725000>;
+ regulator-max-microvolt = <3300000>;
regulator-always-on;
};
@@ -76,8 +76,8 @@
};
ldo5_reg: ldo5 {
- regulator-min-microvolt = <1725000>;
- regulator-max-microvolt = <3300000>;
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <3600000>;
regulator-always-on;
};
@@ -100,14 +100,14 @@
};
ldo9_reg: ldo9 {
- regulator-min-microvolt = <1200000>;
+ regulator-min-microvolt = <1250000>;
regulator-max-microvolt = <3600000>;
regulator-always-on;
};
ldo10_reg: ldo10 {
- regulator-min-microvolt = <1250000>;
- regulator-max-microvolt = <3650000>;
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <3600000>;
regulator-always-on;
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] ARM: dts: imx53-qsb: Fix regulator constraints
2016-04-19 18:15 [PATCH] ARM: dts: imx53-qsb: Fix regulator constraints Fabio Estevam
@ 2016-04-26 3:19 ` Shawn Guo
2016-04-26 11:52 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2016-04-26 3:19 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Apr 19, 2016 at 03:15:05PM -0300, Fabio Estevam wrote:
> Currently the imx53-qsb board with a Dialog DA9053 PMIC fails to boot:
>
> [ 0.397546] LDO3: Bringing 3300000uV into 1800000-1800000uV
>
> The LDO3 voltage constraints passed in the device tree do not match
> the valid range according to the datasheet, so fix this accordingly to
> allow the board booting again.
So you are saying this is a regression? If so, please provide the
commit that introduces the regression.
Shawn
>
> While at that, fix the other voltage constraints as well.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> arch/arm/boot/dts/imx53-qsb.dts | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
> index dec4b07..3799396 100644
> --- a/arch/arm/boot/dts/imx53-qsb.dts
> +++ b/arch/arm/boot/dts/imx53-qsb.dts
> @@ -64,8 +64,8 @@
> };
>
> ldo3_reg: ldo3 {
> - regulator-min-microvolt = <600000>;
> - regulator-max-microvolt = <1800000>;
> + regulator-min-microvolt = <1725000>;
> + regulator-max-microvolt = <3300000>;
> regulator-always-on;
> };
>
> @@ -76,8 +76,8 @@
> };
>
> ldo5_reg: ldo5 {
> - regulator-min-microvolt = <1725000>;
> - regulator-max-microvolt = <3300000>;
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <3600000>;
> regulator-always-on;
> };
>
> @@ -100,14 +100,14 @@
> };
>
> ldo9_reg: ldo9 {
> - regulator-min-microvolt = <1200000>;
> + regulator-min-microvolt = <1250000>;
> regulator-max-microvolt = <3600000>;
> regulator-always-on;
> };
>
> ldo10_reg: ldo10 {
> - regulator-min-microvolt = <1250000>;
> - regulator-max-microvolt = <3650000>;
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <3600000>;
> regulator-always-on;
> };
> };
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ARM: dts: imx53-qsb: Fix regulator constraints
2016-04-26 3:19 ` Shawn Guo
@ 2016-04-26 11:52 ` Fabio Estevam
0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2016-04-26 11:52 UTC (permalink / raw)
To: linux-arm-kernel
Hi Shawn,
On Tue, Apr 26, 2016 at 12:19 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Tue, Apr 19, 2016 at 03:15:05PM -0300, Fabio Estevam wrote:
>> Currently the imx53-qsb board with a Dialog DA9053 PMIC fails to boot:
>>
>> [ 0.397546] LDO3: Bringing 3300000uV into 1800000-1800000uV
>>
>> The LDO3 voltage constraints passed in the device tree do not match
>> the valid range according to the datasheet, so fix this accordingly to
>> allow the board booting again.
>
> So you are saying this is a regression? If so, please provide the
> commit that introduces the regression.
I can boot mainline kernel fine on a mx53qsb with Dialog PMIC. I only
see this issue with linux-next, so it is OK if you only apply this
into your 'for-next' branch.
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-26 11:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-19 18:15 [PATCH] ARM: dts: imx53-qsb: Fix regulator constraints Fabio Estevam
2016-04-26 3:19 ` Shawn Guo
2016-04-26 11:52 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).