From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: pxa: handle bus errors
Date: Tue, 26 Apr 2016 09:04:36 +0530 [thread overview]
Message-ID: <20160426033436.GC2274@localhost> (raw)
In-Reply-To: <1459200744-13245-1-git-send-email-robert.jarzmik@free.fr>
On Mon, Mar 28, 2016 at 11:32:24PM +0200, Robert Jarzmik wrote:
> In the current state, upon bus error the driver will spin endlessly,
> relaunching the last tx, which will fail again and again :
> - a bus error happens
> - pxad_chan_handler() is called
> - as PXA_DCSR_STOPSTATE is true, the last non-terminated transaction is
> lauched, which is the one triggering the bus error, as it didn't
> terminate
> - moreover, the STOP interrupt fires a new, as the STOPIRQEN is still
> active
>
> Break this logic by stopping the automatic relaunch of a dma channel
> upon a bus error, even if there are still pending issued requests on it.
>
> As dma_cookie_status() seems unable to return DMA_ERROR in its current
> form, ie. there seems no way to mark a DMA_ERROR on a per-async-tx
> basis, it is chosen in this patch to remember on the channel which
> transaction failed, and report it in pxad_tx_status().
>
> It's a bit misleading because if T1, T2, T3 and T4 were queued, and T1
> was completed while T2 causes a bus error, the status of T3 and T4 will
> be reported as DMA_IN_PROGRESS, while the channel is actually stopped.
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2016-04-26 3:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 21:32 [PATCH] dmaengine: pxa: handle bus errors Robert Jarzmik
2016-04-13 13:53 ` Vinod Koul
2016-04-14 18:23 ` Robert Jarzmik
2016-04-16 5:18 ` Vinod Koul
2016-04-16 8:09 ` Robert Jarzmik
2016-04-26 3:34 ` Vinod Koul [this message]
2016-04-26 6:19 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426033436.GC2274@localhost \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).