From: s.christ@phytec.de (Stefan Christ)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] gpmi-nand: Handle ECC Errors in erased pages
Date: Tue, 26 Apr 2016 09:51:28 +0200 [thread overview]
Message-ID: <20160426075128.GC2351@lws-christ> (raw)
In-Reply-To: <1461587712-16403-1-git-send-email-mpa@pengutronix.de>
Hi,
On Mon, Apr 25, 2016 at 02:35:12PM +0200, Markus Pargmann wrote:
> ECC is only calculated for written pages. As erased pages are not
> actively written the ECC is always invalid. For this purpose the
> Hardware BCH unit is able to check for erased pages and does not raise
> an ECC error in this case. This behaviour can be influenced using the
> BCH_MODE register which sets the number of allowed bitflips in an erased
> page. Unfortunately the unit is not capable of fixing the bitflips in
> memory.
>
> To avoid complete software checks for erased pages, we can simply check
> buffers with uncorrectable ECC errors because we know that any erased
> page with errors is uncorrectable by the BCH unit.
>
> This patch adds the generic nand_check_erased_ecc_chunk() to gpmi-nand
> to correct erased pages. To have the valid data in the buffer before
> using them, this patch moves the read_page_swap_end() call before the
> ECC status checking for-loop.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> [Squashed patches by Stefan and Boris to check ECC area]
> Cc: Stefan Christ <s.christ@phytec.de>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Tested-by: Stefan Christ <s.christ@phytec.de>
I verified the fix again on our board.
Mit freundlichen Gr??en / Kind regards,
Stefan Christ
next prev parent reply other threads:[~2016-04-26 7:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 12:35 [PATCH v2] gpmi-nand: Handle ECC Errors in erased pages Markus Pargmann
2016-04-25 12:53 ` Boris Brezillon
2016-04-26 7:51 ` Stefan Christ [this message]
2016-04-26 15:14 ` Han Xu
2016-04-26 17:30 ` Boris Brezillon
2016-04-28 8:17 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426075128.GC2351@lws-christ \
--to=s.christ@phytec.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox