From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 26 Apr 2016 10:12:47 -0700 Subject: [PATCH] ARM: dts: omap3: Fix ISP syscon register offset In-Reply-To: <20160422131626.GA7534@earth> References: <1460787628-17316-1-git-send-email-ivo.g.dimitrov.75@gmail.com> <5719A9E3.1000902@gmail.com> <20160422131626.GA7534@earth> Message-ID: <20160426171246.GE5995@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Sebastian Reichel [160422 06:17]: > Hi, > > On Fri, Apr 22, 2016 at 07:34:43AM +0300, Ivaylo Dimitrov wrote: > > On 16.04.2016 09:20, Ivaylo Dimitrov wrote: > > >According to the TRM, SCM CONTROL_CSIRXFE register is on offset 0x6c > > > > > >Signed-off-by: Ivaylo Dimitrov > > >--- > > > arch/arm/boot/dts/omap34xx.dtsi | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > >diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi > > >index 5cdba1f..e446562 100644 > > >--- a/arch/arm/boot/dts/omap34xx.dtsi > > >+++ b/arch/arm/boot/dts/omap34xx.dtsi > > >@@ -46,7 +46,7 @@ > > > 0x480bd800 0x017c>; > > > interrupts = <24>; > > > iommus = <&mmu_isp>; > > >- syscon = <&scm_conf 0xdc>; > > >+ syscon = <&scm_conf 0x6c>; > > > ti,phy-type = ; > > > #clock-cells = <1>; > > > ports { > > > > > You may want to add the hint, that 0xdc (the old, wrong "offset") > represents the last few bits of the register address. I guess > somebody didn't notice, that scm_conf does not start at a register > address ending with 00 (like most other modules). > > Reviewed-By: Sebastian Reichel Applying into omap-for-v4.6/fixes-rc5 thanks. Tony