From: paulmck@linux.vnet.ibm.com (Paul E. McKenney)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH arm 1/1] arm: Use _rcuidle tracepoint to allow use from idle
Date: Tue, 26 Apr 2016 13:36:52 -0700 [thread overview]
Message-ID: <20160426203652.GQ3715@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160426161621.34872b7f@gandalf.local.home>
On Tue, Apr 26, 2016 at 04:16:21PM -0400, Steven Rostedt wrote:
> On Tue, 26 Apr 2016 13:06:13 -0700
> "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
>
> > On Tue, Apr 26, 2016 at 12:51:59PM -0700, Tony Lindgren wrote:
> > > * Steven Rostedt <rostedt@goodmis.org> [160426 12:45]:
> > > > *Whack* *Whack* *Whack*!!!
> > > >
> > > > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> > > > ---
> > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> > > > index fb74dc1f7520..4fa43c02d682 100644
> > > > --- a/drivers/clk/clk.c
> > > > +++ b/drivers/clk/clk.c
> > > > @@ -682,12 +682,12 @@ static void clk_core_disable(struct clk_core *core)
> > > > if (--core->enable_count > 0)
> > > > return;
> > > >
> > > > - trace_clk_disable(core);
> > > > + trace_clk_disable_rcuidle(core);
> > > >
> > > > if (core->ops->disable)
> > > > core->ops->disable(core->hw);
> > > >
> > > > - trace_clk_disable_complete(core);
> > > > + trace_clk_disable_complete_rcuidle(core);
> > > >
> > > > clk_core_disable(core->parent);
> > > > }
> > >
> > > Now the mole shows up here!
> >
> > And the patch shows up here!
> >
> > Thanx, Paul
> >
> > ------------------------------------------------------------------------
> >
> > commit d824fb6beb6e23ade51806e11a882528dc15ae98
> > Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > Date: Tue Apr 26 13:03:51 2016 -0700
> >
> > arm: Whack another event-trace-from-idle mole
> >
> > This commit appends a few _rcuidle suffixes to fix the following
> > RCU-used-from-idle bug:
> >
> > > ===============================
> > > [ INFO: suspicious RCU usage. ]
> > > 4.6.0-rc5-next-20160426+ #1116 Not tainted
> > > -------------------------------
> > > include/trace/events/rpm.h:95 suspicious rcu_dereference_check() usage!
> > >
> > > other info that might help us debug this:
> > >
> > >
> > > RCU used illegally from idle CPU!
> > > rcu_scheduler_active = 1, debug_locks = 0
> > > RCU used illegally from extended quiescent state!
> > > 1 lock held by swapper/0/0:
> > > #0: (&(&dev->power.lock)->rlock){-.-...}, at: [<c052cc2c>] __rpm_callback+0x58/0x60
> > >
> > > stack backtrace:
> > > CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1116
> > > Hardware name: Generic OMAP36xx (Flattened Device Tree)
> > > [<c0110290>] (unwind_backtrace) from [<c010c3a8>] (show_stack+0x10/0x14)
> > > [<c010c3a8>] (show_stack) from [<c047fd68>] (dump_stack+0xb0/0xe4)
> > > [<c047fd68>] (dump_stack) from [<c052d5d0>] (rpm_suspend+0x580/0x768)
> > > [<c052d5d0>] (rpm_suspend) from [<c052ec58>] (__pm_runtime_suspend+0x64/0x84)
> > > [<c052ec58>] (__pm_runtime_suspend) from [<c04bf25c>] (omap2_gpio_prepare_for_idle+0x5c/0x70)
> > > [<c04bf25c>] (omap2_gpio_prepare_for_idle) from [<c0125568>] (omap_sram_idle+0x140/0x244)
> > > [<c0125568>] (omap_sram_idle) from [<c01269dc>] (omap3_enter_idle_bm+0xfc/0x1ec)
> > > [<c01269dc>] (omap3_enter_idle_bm) from [<c0601bdc>] (cpuidle_enter_state+0x80/0x3d4)
> > > [<c0601bdc>] (cpuidle_enter_state) from [<c0183b08>] (cpu_startup_entry+0x198/0x3a0)
> > > [<c0183b08>] (cpu_startup_entry) from [<c0b00c0c>] (start_kernel+0x354/0x3c8)
> > > [<c0b00c0c>] (start_kernel) from [<8000807c>] (0x8000807c)
> >
> > In the immortal words of Steven Rostedt, "*Whack* *Whack* *Whack*!!!"
>
> WhACKED-by: Steven Rostedt <rostedt@goodmis.org>
I whacked in your WhACKED-by.
Thanx, Paul
next prev parent reply other threads:[~2016-04-26 20:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 20:48 [PATCH arm 1/1] arm: Use _rcuidle tracepoint to allow use from idle Paul E. McKenney
2016-04-26 15:00 ` Tony Lindgren
2016-04-26 17:52 ` Paul E. McKenney
2016-04-26 18:29 ` Tony Lindgren
2016-04-26 19:07 ` Paul E. McKenney
2016-04-26 19:39 ` Tony Lindgren
2016-04-26 19:44 ` Steven Rostedt
2016-04-26 19:51 ` Paul E. McKenney
2016-04-26 19:52 ` Steven Rostedt
2016-04-26 20:06 ` Paul E. McKenney
2016-04-26 19:51 ` Tony Lindgren
2016-04-26 20:06 ` Paul E. McKenney
2016-04-26 20:11 ` Paul E. McKenney
2016-04-26 20:25 ` Tony Lindgren
2016-04-26 20:41 ` Paul E. McKenney
2016-04-26 20:46 ` Tony Lindgren
2016-04-26 20:52 ` Steven Rostedt
2016-04-26 21:08 ` Paul E. McKenney
2016-04-26 21:04 ` Paul E. McKenney
2016-04-26 21:12 ` Tony Lindgren
2016-04-26 21:26 ` Paul E. McKenney
2016-04-26 21:36 ` Tony Lindgren
2016-04-26 20:16 ` Steven Rostedt
2016-04-26 20:36 ` Paul E. McKenney [this message]
2016-04-26 19:47 ` Paul E. McKenney
2016-04-26 19:17 ` Steven Rostedt
2016-04-26 19:41 ` Tony Lindgren
2016-04-26 19:42 ` Paul E. McKenney
2016-04-26 19:49 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426203652.GQ3715@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).