From: jszhang@marvell.com (Jisheng Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: reboot: remove duplicated local_irq_disable()
Date: Wed, 27 Apr 2016 17:22:11 +0800 [thread overview]
Message-ID: <20160427172211.395b846a@xhacker> (raw)
In-Reply-To: <1459320308-4584-1-git-send-email-jszhang@marvell.com>
Dear Russell,
On Wed, 30 Mar 2016 14:45:08 +0800 Jisheng Zhang wrote:
> Once entering machine_halt() and machine_restart(), local_irq_disable()
> is called, and local irq is kept disabled, so the local_irq_disable()
> at the end of these two functions are not necessary, remove it.
Could I put the patch in your patch tracking system?
Thanks,
Jisheng
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
>
> Since v1:
> - correct typo in commit msg
>
> arch/arm/kernel/reboot.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm/kernel/reboot.c b/arch/arm/kernel/reboot.c
> index 71a2ff9..3fa867a 100644
> --- a/arch/arm/kernel/reboot.c
> +++ b/arch/arm/kernel/reboot.c
> @@ -104,8 +104,6 @@ void machine_halt(void)
> {
> local_irq_disable();
> smp_send_stop();
> -
> - local_irq_disable();
> while (1);
> }
>
> @@ -150,6 +148,5 @@ void machine_restart(char *cmd)
>
> /* Whoops - the platform was unable to reboot. Tell the user! */
> printk("Reboot failed -- System halted\n");
> - local_irq_disable();
> while (1);
> }
next prev parent reply other threads:[~2016-04-27 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 6:45 [PATCH v2] ARM: reboot: remove duplicated local_irq_disable() Jisheng Zhang
2016-04-27 9:22 ` Jisheng Zhang [this message]
2016-04-28 13:45 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427172211.395b846a@xhacker \
--to=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).