From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 4/7] Documentation: dt: socfpga: Add Arria10 Ethernet binding
Date: Wed, 27 Apr 2016 21:51:44 -0500 [thread overview]
Message-ID: <20160428025144.GA5837@rob-hp-laptop> (raw)
In-Reply-To: <1461606768-14404-5-git-send-email-tthayer@opensource.altera.com>
On Mon, Apr 25, 2016 at 12:52:45PM -0500, tthayer at opensource.altera.com wrote:
> From: Thor Thayer <tthayer@opensource.altera.com>
>
> Add the device tree bindings needed to support the Altera Ethernet
> FIFO buffers on the Arria10 chip.
>
> Signed-off-by: Thor Thayer <tthayer@opensource.altera.com>
> ---
> v2 No Change
> ---
> .../bindings/arm/altera/socfpga-eccmgr.txt | 24 ++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt b/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt
> index 5a6b160..aa1c593 100644
> --- a/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt
> +++ b/Documentation/devicetree/bindings/arm/altera/socfpga-eccmgr.txt
> @@ -76,6 +76,18 @@ Required Properties:
> - compatible : Should be "altr,socfpga-a10-ocram-ecc"
> - reg : Address and size for ECC block registers.
>
> +Ethernet FIFO ECC
> +Required Properties:
> +- compatible : Should be "altr,socfpga-a10-emac0-rx-ecc" for the 1st EMAC
> + Receive buffer
> + or "altr,socfpga-a10-emac0-tx-ecc" for the 1st EMAC Transmit buffer
> + or "altr,socfpga-a10-emac1-rx-ecc" for the 2nd EMAC Receive buffer
> + or "altr,socfpga-a10-emac1-tx-ecc" for the 2nd EMAC Transmit buffer
> + or "altr,socfpga-a10-emac2-rx-ecc" for the 3rd EMAC Receive buffer
> + or "altr,socfpga-a10-emac2-tx-ecc" for the 3rd EMAC Transmit buffer
These blocks don't really appear to be different other than the
interrupt mask (which is in another block?). I think they should be the
same compatible with a property for the interrupt (perhaps a full
interrupt-controller binding).
> +- reg : Address and size for ECC block registers.
> +- parent : phandle to parent Ethernet node.
Needs a better name and altr prefix. Maybe altr,eth-mac?
Rob
next prev parent reply other threads:[~2016-04-28 2:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 17:52 [PATCHv2 0/7] Add EDAC peripheral init functions & Ethernet EDAC tthayer at opensource.altera.com
2016-04-25 17:52 ` [PATCHv2 1/7] EDAC, altera: Check parent status for Arria10 EDAC block tthayer at opensource.altera.com
2016-04-25 17:52 ` [PATCHv2 2/7] EDAC, altera: Add panic flag check to A10 IRQ tthayer at opensource.altera.com
2016-04-25 17:52 ` [PATCHv2 3/7] EDAC, altera: Move Arria10 IRQ function tthayer at opensource.altera.com
2016-04-25 17:52 ` [PATCHv2 4/7] Documentation: dt: socfpga: Add Arria10 Ethernet binding tthayer at opensource.altera.com
2016-04-28 2:51 ` Rob Herring [this message]
2016-04-25 17:52 ` [PATCHv2 5/7] EDAC, altera: Add Arria10 ECC memory init functions tthayer at opensource.altera.com
2016-04-25 17:52 ` [PATCHv2 6/7] EDAC, altera: Add Arria10 Ethernet EDAC support tthayer at opensource.altera.com
2016-04-25 17:52 ` [PATCHv2 7/7] ARM: dts: Add Arria10 Ethernet EDAC devicetree entry tthayer at opensource.altera.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428025144.GA5837@rob-hp-laptop \
--to=robh@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox