* [PATCH] arm64: Drop CONFIG_RTC_LIB dependency
@ 2016-04-27 16:55 Ezequiel Garcia
2016-04-28 12:24 ` Will Deacon
2016-04-28 12:33 ` Arnd Bergmann
0 siblings, 2 replies; 5+ messages in thread
From: Ezequiel Garcia @ 2016-04-27 16:55 UTC (permalink / raw)
To: linux-arm-kernel
The rtc-lib dependency is not required, and seems it was just
copy-pasted from ARM's Kconfig. If platform requires rtc-lib,
they should select it individually.
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
---
arch/arm64/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index c8762f4613f0..b9d0a81d391c 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -99,7 +99,6 @@ config ARM64
select PERF_USE_VMALLOC
select POWER_RESET
select POWER_SUPPLY
- select RTC_LIB
select SPARSE_IRQ
select SYSCTL_EXCEPTION_TRACE
help
--
2.7.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] arm64: Drop CONFIG_RTC_LIB dependency
2016-04-27 16:55 [PATCH] arm64: Drop CONFIG_RTC_LIB dependency Ezequiel Garcia
@ 2016-04-28 12:24 ` Will Deacon
2016-04-28 12:29 ` Arnd Bergmann
2016-04-28 12:33 ` Arnd Bergmann
1 sibling, 1 reply; 5+ messages in thread
From: Will Deacon @ 2016-04-28 12:24 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Apr 27, 2016 at 01:55:28PM -0300, Ezequiel Garcia wrote:
> The rtc-lib dependency is not required, and seems it was just
> copy-pasted from ARM's Kconfig. If platform requires rtc-lib,
> they should select it individually.
Are you sure this doesn't break any platforms that are relying on this
implicit select?
Will
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
> arch/arm64/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index c8762f4613f0..b9d0a81d391c 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -99,7 +99,6 @@ config ARM64
> select PERF_USE_VMALLOC
> select POWER_RESET
> select POWER_SUPPLY
> - select RTC_LIB
> select SPARSE_IRQ
> select SYSCTL_EXCEPTION_TRACE
> help
> --
> 2.7.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: Drop CONFIG_RTC_LIB dependency
2016-04-28 12:24 ` Will Deacon
@ 2016-04-28 12:29 ` Arnd Bergmann
2016-04-28 12:31 ` Will Deacon
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2016-04-28 12:29 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 28 April 2016 13:24:25 Will Deacon wrote:
> On Wed, Apr 27, 2016 at 01:55:28PM -0300, Ezequiel Garcia wrote:
> > The rtc-lib dependency is not required, and seems it was just
> > copy-pasted from ARM's Kconfig. If platform requires rtc-lib,
> > they should select it individually.
>
> Are you sure this doesn't break any platforms that are relying on this
> implicit select?
>
I have checked this carefully. I actually had a patch that removed this
from all of the kernel, but then found some users on other architectures.
ARM and ARM64 both don't use it.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: Drop CONFIG_RTC_LIB dependency
2016-04-28 12:29 ` Arnd Bergmann
@ 2016-04-28 12:31 ` Will Deacon
0 siblings, 0 replies; 5+ messages in thread
From: Will Deacon @ 2016-04-28 12:31 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Apr 28, 2016 at 02:29:34PM +0200, Arnd Bergmann wrote:
> On Thursday 28 April 2016 13:24:25 Will Deacon wrote:
> > On Wed, Apr 27, 2016 at 01:55:28PM -0300, Ezequiel Garcia wrote:
> > > The rtc-lib dependency is not required, and seems it was just
> > > copy-pasted from ARM's Kconfig. If platform requires rtc-lib,
> > > they should select it individually.
> >
> > Are you sure this doesn't break any platforms that are relying on this
> > implicit select?
> >
>
> I have checked this carefully. I actually had a patch that removed this
> from all of the kernel, but then found some users on other architectures.
> ARM and ARM64 both don't use it.
Great, thanks Arnd. Can I add your reviewed-by to this patch then, please?
Will
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: Drop CONFIG_RTC_LIB dependency
2016-04-27 16:55 [PATCH] arm64: Drop CONFIG_RTC_LIB dependency Ezequiel Garcia
2016-04-28 12:24 ` Will Deacon
@ 2016-04-28 12:33 ` Arnd Bergmann
1 sibling, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2016-04-28 12:33 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 27 April 2016 13:55:28 Ezequiel Garcia wrote:
> The rtc-lib dependency is not required, and seems it was just
> copy-pasted from ARM's Kconfig. If platform requires rtc-lib,
> they should select it individually.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
Reviewed-by:
> arch/arm64/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index c8762f4613f0..b9d0a81d391c 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -99,7 +99,6 @@ config ARM64
> select PERF_USE_VMALLOC
> select POWER_RESET
> select POWER_SUPPLY
> - select RTC_LIB
> select SPARSE_IRQ
> select SYSCTL_EXCEPTION_TRACE
> help
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-28 12:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-27 16:55 [PATCH] arm64: Drop CONFIG_RTC_LIB dependency Ezequiel Garcia
2016-04-28 12:24 ` Will Deacon
2016-04-28 12:29 ` Arnd Bergmann
2016-04-28 12:31 ` Will Deacon
2016-04-28 12:33 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox