public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 2/9] ARM: dts: am437x: Add missing compatibles to PWM binding documents
Date: Thu, 28 Apr 2016 16:07:16 -0500	[thread overview]
Message-ID: <20160428210716.GA12508@rob-hp-laptop> (raw)
In-Reply-To: <1461710209-6563-3-git-send-email-fcooper@ti.com>

On Tue, Apr 26, 2016 at 05:36:42PM -0500, Franklin S Cooper Jr wrote:
> There are several SOC specific compatibles for ECAP, EHRPWM and PWMMS
> that are in use but aren't properly documented. Therefore, fix this
> by adding the compatibles to the appropriate binding documents.
> 
> While at it make minor corrections to the binding document.
> 
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>  .../devicetree/bindings/pwm/pwm-tiecap.txt          | 12 ++++++++++--
>  .../devicetree/bindings/pwm/pwm-tiehrpwm.txt        | 12 ++++++++++--
>  .../devicetree/bindings/pwm/pwm-tipwmss.txt         | 21 +++++++++++++++++++--
>  3 files changed, 39 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> index fb81179..788da6c 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> +++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> @@ -2,8 +2,9 @@ TI SOC ECAP based APWM controller
>  
>  Required properties:
>  - compatible: Must be "ti,<soc>-ecap".
> -  for am33xx - compatible = "ti,am33xx-ecap";
> -  for da850  - compatible = "ti,da850-ecap", "ti,am33xx-ecap";
> +  for am33xx  - compatible = "ti,am33xx-ecap";
> +  for am4372  - compatible = "ti,am4372-ecap", "ti,am33xx-ecap";
> +  for da850   - compatible = "ti,da850-ecap", "ti,am33xx-ecap";
>  - #pwm-cells: should be 3. See pwm.txt in this directory for a description of
>    the cells format. The PWM channel index ranges from 0 to 4. The only third
>    cell flag supported by this binding is PWM_POLARITY_INVERTED.
> @@ -22,6 +23,13 @@ ecap0: ecap at 0 { /* ECAP on am33xx */
>  	ti,hwmods = "ecap0";
>  };
>  
> +ecap0: ecap at 0 { /* ECAP on am4372 */

The unit address is wrong.

> +	compatible = "ti,am4372-ecap", "ti,am33xx-ecap";
> +	#pwm-cells = <3>;
> +	reg = <0x48300100 0x80>;
> +	ti,hwmods = "ecap0";
> +};
> +
>  ecap0: ecap at 0 { /* ECAP on da850 */
>  	compatible = "ti,da850-ecap", "ti,am33xx-ecap";
>  	#pwm-cells = <3>;
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
> index 9c100b2..99b544f 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
> +++ b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
> @@ -2,8 +2,9 @@ TI SOC EHRPWM based PWM controller
>  
>  Required properties:
>  - compatible: Must be "ti,<soc>-ehrpwm".
> -  for am33xx - compatible = "ti,am33xx-ehrpwm";
> -  for da850  - compatible = "ti,da850-ehrpwm", "ti,am33xx-ehrpwm";
> +  for am33xx  - compatible = "ti,am33xx-ehrpwm";
> +  for am4372  - compatible = "ti,am4372-ehrpwm", "ti,am33xx-ehrpwm";
> +  for da850   - compatible = "ti,da850-ehrpwm", "ti,am33xx-ehrpwm";
>  - #pwm-cells: should be 3. See pwm.txt in this directory for a description of
>    the cells format. The only third cell flag supported by this binding is
>    PWM_POLARITY_INVERTED.
> @@ -22,6 +23,13 @@ ehrpwm0: ehrpwm at 0 { /* EHRPWM on am33xx */
>  	ti,hwmods = "ehrpwm0";
>  };
>  
> +ehrpwm0: ehrpwm at 0 { /* EHRPWM on am4372 */

ditto

Otherwise,

Acked-by: Rob Herring <robh@kernel.org>

  reply	other threads:[~2016-04-28 21:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 22:36 [PATCH v7 0/9] ARM: dts: DRA7: Add dt nodes for PWMSS Franklin S Cooper Jr
2016-04-26 22:36 ` [PATCH v7 1/9] clk: ti: am335x/am4372: Add tbclk to pwm node Franklin S Cooper Jr
2016-04-27 12:48   ` Tero Kristo
2016-04-26 22:36 ` [PATCH v7 2/9] ARM: dts: am437x: Add missing compatibles to PWM binding documents Franklin S Cooper Jr
2016-04-28 21:07   ` Rob Herring [this message]
2016-04-28 21:11     ` Franklin S Cooper Jr.
2016-04-28 21:55       ` Rob Herring
2016-04-26 22:36 ` [PATCH v7 3/9] pwm: pwm-tiehrpwm: Update dt binding document to use generic node name Franklin S Cooper Jr
2016-04-26 22:36 ` [PATCH v7 4/9] pwm: pwm-tiecap: Update dt binding document to use proper unit address Franklin S Cooper Jr
2016-04-28 21:31   ` Rob Herring
2016-04-28 21:41     ` Franklin S Cooper Jr.
2016-04-26 22:36 ` [PATCH v7 5/9] ARM: dts: am437x/am33xx/da850: Add new ECAP and EPWM bindings Franklin S Cooper Jr
2016-04-28 21:35   ` Rob Herring
2016-04-26 22:36 ` [PATCH v7 6/9] pwms: pwm-ti*: Get the clock from the PWMSS parent when using old bindings Franklin S Cooper Jr
2016-04-26 22:36 ` [PATCH v7 7/9] ARM: dts: am437x/am33xx: Remove hwmod entries for ECAP and EPWM nodes Franklin S Cooper Jr
2016-04-26 22:36 ` [PATCH v7 8/9] ARM: AM335x/AM437x: hwmod: Remove eQEP, ePWM and eCAP hwmod entries Franklin S Cooper Jr
2016-04-26 22:36 ` [PATCH v7 9/9] ARM: dts: DRA7: Add dt nodes for PWMSS Franklin S Cooper Jr
2016-04-27 19:32 ` [PATCH v7 0/9] " Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160428210716.GA12508@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox