linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: Fix igepv5 audiopwon-gpio
Date: Mon, 9 May 2016 12:44:32 -0700	[thread overview]
Message-ID: <20160509194431.GK5995@atomide.com> (raw)
In-Reply-To: <1b37fbdd-67f0-e9e3-d442-bdc0bd74397b@ti.com>

* Peter Ujfalusi <peter.ujfalusi@ti.com> [160509 01:36]:
> On 05/05/16 21:56, Tony Lindgren wrote:
> > Playing audio works on omap5-uevm, but produces an "Unhandled fault:
> > imprecise external abort (0x1406) at 0x00000000" error on igepv5.
> > 
> > Looks like the twl6040 audpwron GPIO pin is different for these
> > boards. Let's fix the issue by configuring the audpwron in the
> > board specific dts file.
> > 
> > Cc: Agust? Fontquerni <af@iseebcn.com>
> > Cc: Eduard Gavin <egavin@iseebcn.com>
> > Cc: Enric Balletbo i Serra <eballetbo@iseebcn.com>
> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > ---
> >  arch/arm/boot/dts/omap5-board-common.dtsi |  3 ++-
> >  arch/arm/boot/dts/omap5-igep0050.dts      | 10 ++++++++++
> >  arch/arm/boot/dts/omap5-uevm.dts          | 10 ++++++++++
> >  3 files changed, 22 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
> > index 2eea26c..23b1d7c 100644
> > --- a/arch/arm/boot/dts/omap5-board-common.dtsi
> > +++ b/arch/arm/boot/dts/omap5-board-common.dtsi
> > @@ -642,7 +642,8 @@
> >  		pinctrl-0 = <&twl6040_pins>;
> >  
> >  		interrupts = <GIC_SPI 119 IRQ_TYPE_NONE>; /* IRQ_SYS_2N cascaded to gic */
> > -		ti,audpwron-gpio = <&gpio5 13 GPIO_ACTIVE_HIGH>;  /* gpio line 141 */
> > +
> > +		/* audpwron gpio defined in the board specific dts */
> >  
> >  		vio-supply = <&smps7_reg>;
> >  		v2v1-supply = <&smps9_reg>;
> > diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts
> > index 72ff6a4..673cdfa 100644
> > --- a/arch/arm/boot/dts/omap5-igep0050.dts
> > +++ b/arch/arm/boot/dts/omap5-igep0050.dts
> > @@ -58,3 +58,13 @@
> >  		<&gpio7 3 0>;		/* 195, SDA */
> >  };
> >  
> > +&twl6040 {
> > +	ti,audpwron-gpio = <&gpio5 16 GPIO_ACTIVE_HIGH>;  /* gpio line 144 */
> 
> BTW: how do you know that gpio144 is used as audpwron GPIO on igepv5?

>From looking at the ISEE git tree. But it would be best for the ISEE guys
to review the patch.

> > +};
> > +
> > +&twl6040_pins {
> > +	pinctrl-single,pins = <
> > +		OMAP5_IOPAD(0x1c4, PIN_OUTPUT | MUX_MODE6)	/* mcspi1_somi.gpio5_144 */
> > +		OMAP5_IOPAD(0x1ca, PIN_OUTPUT | MUX_MODE6)	/* perslimbus2_clock.gpio5_145 */
> 
> What does the gpio145 is used for?

No idea without seeing the schematics, also from ISEE git tree so should
be reviewed.

Regards,

Tony

      parent reply	other threads:[~2016-05-09 19:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-05 18:56 [PATCH] ARM: dts: Fix igepv5 audiopwon-gpio Tony Lindgren
2016-05-09  8:31 ` Peter Ujfalusi
2016-05-09  8:34 ` Peter Ujfalusi
2016-05-09  8:39   ` Enric Balletbo i Serra
2016-05-09 19:42     ` Tony Lindgren
2016-05-09 19:44   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160509194431.GK5995@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).