From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Wed, 11 May 2016 09:14:29 -0500 Subject: [PATCH 4/7] [media] ir-rx51: add DT support to driver In-Reply-To: <20160510021826.GE1129@earth> References: <1462634508-24961-1-git-send-email-ivo.g.dimitrov.75@gmail.com> <1462634508-24961-5-git-send-email-ivo.g.dimitrov.75@gmail.com> <20160509200657.GA3379@rob-hp-laptop> <5730F8BA.5000402@gmail.com> <20160510021826.GE1129@earth> Message-ID: <20160511141429.GA5894@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, May 10, 2016 at 04:18:27AM +0200, Sebastian Reichel wrote: > Hi, > > On Mon, May 09, 2016 at 04:07:35PM -0500, Rob Herring wrote: > > There's already a pwm-led binding that can be used. Though there > > may be missing consumer IR to LED subsystem support in the kernel. > > You could list both compatibles, use the rx51 IR driver now, and > > then move to pwm-led driver in the future. > > Well from a purely HW point of view it's a PWM connected led. The > usage is completely different though. Usually PWM is used to control > the LED's brightness via the duty cycle (basic concept: enabling led > only 50% of time reduces brightness to 50%). > > In the IR led's case the aim is generating a specific serial pattern > instead. For this task it uses a dmtimer in PWM mode and a second > one to reconfigure the pwm timer. In that case, it will probably never be a generic driver. > I don't know about a good name, but rx51 should be replaced with > n900 in the compatible string. So maybe "nokia,n900-infrared-diode". That's fine, but the shorter '-ir' was too. Rob