linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: konrad.wilk@oracle.com (Konrad Rzeszutek Wilk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv6 2/8] dma-debug: add support for resource mappings
Date: Tue, 17 May 2016 10:50:02 -0400	[thread overview]
Message-ID: <20160517145002.GD4074@char.us.oracle.com> (raw)
In-Reply-To: <1462812247-3414-3-git-send-email-niklas.soderlund+renesas@ragnatech.se>

> +void debug_dma_map_resource(struct device *dev, phys_addr_t addr, size_t size,
> +			    int direction, dma_addr_t dma_addr)
> +{
> +	struct dma_debug_entry *entry;
> +
> +	if (unlikely(dma_debug_disabled()))
> +		return;
> +
> +	entry = dma_entry_alloc();
> +	if (!entry)
> +		return;
> +
> +	entry->type		= dma_debug_resource;
> +	entry->dev		= dev;
> +	entry->pfn		= __phys_to_pfn(addr);
> +	entry->offset		= addr - PHYS_PFN(entry->pfn);

Is that right? 

__phys_to_pfn(addr) is PHYS_PFN(addr), so what you get here is

addr - PHYS_PFN(PHYS_PFN(addr)) ?


> +	entry->size		= size;
> +	entry->dev_addr		= dma_addr;
> +	entry->direction	= direction;
> +	entry->map_err_type	= MAP_ERR_NOT_CHECKED;
> +
> +	add_dma_entry(entry);
> +}
> +EXPORT_SYMBOL(debug_dma_map_resource);
> +

  reply	other threads:[~2016-05-17 14:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-09 16:43 [PATCHv6 0/8] dmaengine: rcar-dmac: add iommu support for slave transfers Niklas Söderlund
2016-05-09 16:44 ` [PATCHv6 1/8] dma-mapping: add {map,unmap}_resource to dma_map_ops Niklas Söderlund
2016-05-09 16:44 ` [PATCHv6 2/8] dma-debug: add support for resource mappings Niklas Söderlund
2016-05-17 14:50   ` Konrad Rzeszutek Wilk [this message]
2016-05-19 11:21     ` Niklas Söderlund
2016-05-19 11:42       ` Robin Murphy
2016-05-09 16:44 ` [PATCHv6 3/8] dma-mapping: add dma_{map,unmap}_resource Niklas Söderlund
2016-05-17 14:54   ` Konrad Rzeszutek Wilk
2016-05-19 11:29     ` Niklas Söderlund
2016-05-19 14:22       ` Konrad Rzeszutek Wilk
2016-05-09 16:44 ` [PATCHv6 4/8] arm: dma-mapping: add {map, unmap}_resource for iommu ops Niklas Söderlund
2016-05-09 16:44 ` [PATCHv6 5/8] dmaengine: rcar-dmac: group slave configuration Niklas Söderlund
2016-05-09 16:44 ` [PATCHv6 6/8] dmaengine: rcar-dmac: add iommu support for slave transfers Niklas Söderlund
2016-05-09 16:44 ` [PATCHv6 7/8] ARM: dts: r8a7790: add iommus to dmac0 and dmac1 Niklas Söderlund
2016-05-09 16:44 ` [PATCHv6 8/8] ARM: dts: r8a7791: " Niklas Söderlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160517145002.GD4074@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).