From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] Revert "mtd: atmel_nand: Support variable RB_EDGE interrupts"
Date: Thu, 26 May 2016 08:36:15 +0200 [thread overview]
Message-ID: <20160526083615.6960686d@bbrezillon> (raw)
In-Reply-To: <20160526031654.GA107505@google.com>
On Wed, 25 May 2016 20:16:54 -0700
Brian Norris <computersforpeace@gmail.com> wrote:
> Hi,
>
> On Mon, May 09, 2016 at 02:51:18PM +0800, Wenyou Yang wrote:
> > This reverts commit 5ddc7bd43ccc ("mtd: atmel_nand: Support variable
> > RB_EDGE interrupts")
> >
> > Because for current SoCs, the RB_EDGE3(i.e. bit 27) of HSMC_SR
> > register does not exist, the RB_EDGE0 (i.e. bit 24) is the ready/busy
> > line edge status bit. It is a datasheet bug.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > ---
> >
> > .../devicetree/bindings/mtd/atmel-nand.txt | 2 +-
> > drivers/mtd/nand/atmel_nand.c | 35 +++++-----------------
> > drivers/mtd/nand/atmel_nand_nfc.h | 3 +-
> > 3 files changed, 10 insertions(+), 30 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/atmel-nand.txt b/Documentation/devicetree/bindings/mtd/atmel-nand.txt
> > index d53aba9..3e7ee99 100644
> > --- a/Documentation/devicetree/bindings/mtd/atmel-nand.txt
> > +++ b/Documentation/devicetree/bindings/mtd/atmel-nand.txt
> > @@ -39,7 +39,7 @@ Optional properties:
> >
> > Nand Flash Controller(NFC) is an optional sub-node
> > Required properties:
> > -- compatible : "atmel,sama5d3-nfc" or "atmel,sama5d4-nfc".
> > +- compatible : "atmel,sama5d3-nfc".
> > - reg : should specify the address and size used for NFC command registers,
> > NFC registers and NFC SRAM. NFC SRAM address and size can be absent
> > if don't want to use it.
> > diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
> > index efc8ea2..68b9160 100644
> > --- a/drivers/mtd/nand/atmel_nand.c
> > +++ b/drivers/mtd/nand/atmel_nand.c
> [...]
> > static const struct of_device_id atmel_nand_nfc_match[] = {
> > - { .compatible = "atmel,sama5d3-nfc", .data = &sama5d3_nfc_caps },
> > - { .compatible = "atmel,sama5d4-nfc", .data = &sama5d4_nfc_caps },
> > + { .compatible = "atmel,sama5d3-nfc" },
>
> Hmm, wait. Didn't Rob and Alexandre suggest that we should *not* drop
> the compatible property? We could have easily supported both here, and
> just not listed any different capabilities. But I see that Nicholas took
> the patch anyway, so I guess it's not a big deal...
Yes, actually the compatible change was introduced and fixed in the
same release, so I don't think the stable ABI argument stands here.
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-05-26 6:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 6:51 [PATCH 0/2] mtd: atmel_nand: remove compatible "atmel,sama5d4-nfc" Wenyou Yang
2016-05-09 6:51 ` [PATCH 1/2] Revert "mtd: atmel_nand: Support variable RB_EDGE interrupts" Wenyou Yang
2016-05-10 8:55 ` Boris Brezillon
2016-05-10 8:59 ` Yang, Wenyou
2016-05-10 9:59 ` Romain Izard
2016-05-23 7:55 ` Boris Brezillon
2016-05-26 3:10 ` Brian Norris
2016-05-26 3:16 ` Brian Norris
2016-05-26 6:36 ` Boris Brezillon [this message]
2016-05-09 6:51 ` [PATCH 2/2] ARM: at91/dt: use "atmel,sama5d3-nfc" compatible for nfc Wenyou Yang
2016-05-09 16:34 ` [PATCH] ARM: dts: at91: sama5d2: use "atmel, sama5d3-nfc" " Nicolas Ferre
2016-05-09 17:17 ` [PATCH] ARM: dts: at91: sama5d2: use "atmel,sama5d3-nfc" " Romain Izard
2016-05-09 20:13 ` [PATCH 0/2] mtd: atmel_nand: remove compatible "atmel,sama5d4-nfc" Rob Herring
2016-05-10 4:50 ` Yang, Wenyou
2016-05-10 11:52 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160526083615.6960686d@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).