linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] ARM: dts: sun5i: a10s: add spi2 pins
@ 2016-05-26 19:25 Michal Suchanek
  2016-05-26 19:25 ` [PATCH 2/3] ARM: dts: sun5i: add spi2 on A10s Olinuxino Micro Michal Suchanek
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Michal Suchanek @ 2016-05-26 19:25 UTC (permalink / raw)
  To: linux-arm-kernel

Used on A10s Olinuxino.

Signed-off-by: Michal Suchanek <hramrach@gmail.com>
---
 arch/arm/boot/dts/sun5i-a10s.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/sun5i-a10s.dtsi b/arch/arm/boot/dts/sun5i-a10s.dtsi
index bddd0de..651837c 100644
--- a/arch/arm/boot/dts/sun5i-a10s.dtsi
+++ b/arch/arm/boot/dts/sun5i-a10s.dtsi
@@ -241,6 +241,20 @@
 		allwinner,drive = <SUN4I_PINCTRL_30_MA>;
 		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
 	};
+
+	spi2_pins_a: spi2 at 0 {
+		allwinner,pins = "PB12", "PB13", "PB14";
+		allwinner,function = "spi2";
+		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+	};
+
+	spi2_cs0_pins_a: spi2_cs0 at 0 {
+		allwinner,pins = "PB11";
+		allwinner,function = "spi2";
+		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+	};
 };
 
 &sram_a {
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/3] ARM: dts: sun5i: add spi2 on A10s Olinuxino Micro
  2016-05-26 19:25 [PATCH 1/3] ARM: dts: sun5i: a10s: add spi2 pins Michal Suchanek
@ 2016-05-26 19:25 ` Michal Suchanek
  2016-05-30  8:09   ` Maxime Ripard
  2016-05-26 19:25 ` [PATCH 3/3] ARM: dts: sun5i: Add spi2 alias on A10s Olinuxino Michal Suchanek
  2016-05-30  8:08 ` [PATCH 1/3] ARM: dts: sun5i: a10s: add spi2 pins Maxime Ripard
  2 siblings, 1 reply; 6+ messages in thread
From: Michal Suchanek @ 2016-05-26 19:25 UTC (permalink / raw)
  To: linux-arm-kernel

spi2 is available on the UEXT connector

Signed-off-by: Michal Suchanek <hramrach@gmail.com>
---
 arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts b/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts
index 86d046a..7d2ff60 100644
--- a/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts
+++ b/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts
@@ -192,6 +192,13 @@
 	status = "okay";
 };
 
+&spi2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&spi2_pins_a>,
+		    <&spi2_cs0_pins_a>;
+	status = "okay";
+};
+
 &ohci0 {
 	status = "okay";
 };
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/3] ARM: dts: sun5i: Add spi2 alias on A10s Olinuxino
  2016-05-26 19:25 [PATCH 1/3] ARM: dts: sun5i: a10s: add spi2 pins Michal Suchanek
  2016-05-26 19:25 ` [PATCH 2/3] ARM: dts: sun5i: add spi2 on A10s Olinuxino Micro Michal Suchanek
@ 2016-05-26 19:25 ` Michal Suchanek
  2016-05-30  8:29   ` Maxime Ripard
  2016-05-30  8:08 ` [PATCH 1/3] ARM: dts: sun5i: a10s: add spi2 pins Maxime Ripard
  2 siblings, 1 reply; 6+ messages in thread
From: Michal Suchanek @ 2016-05-26 19:25 UTC (permalink / raw)
  To: linux-arm-kernel

spi2 is available on the UEXT connector

The bus is named spi2 in the A10s manual and Olinuxino manual so it is
pointless to alias it to something else like spi0.

Signed-off-by: Michal Suchanek <hramrach@gmail.com>
---
 arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts b/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts
index 7d2ff60..9729c37 100644
--- a/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts
+++ b/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts
@@ -58,6 +58,7 @@
 		serial0 = &uart0;
 		serial1 = &uart2;
 		serial2 = &uart3;
+		spi2 = &spi2;
 	};
 
 	chosen {
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 1/3] ARM: dts: sun5i: a10s: add spi2 pins
  2016-05-26 19:25 [PATCH 1/3] ARM: dts: sun5i: a10s: add spi2 pins Michal Suchanek
  2016-05-26 19:25 ` [PATCH 2/3] ARM: dts: sun5i: add spi2 on A10s Olinuxino Micro Michal Suchanek
  2016-05-26 19:25 ` [PATCH 3/3] ARM: dts: sun5i: Add spi2 alias on A10s Olinuxino Michal Suchanek
@ 2016-05-30  8:08 ` Maxime Ripard
  2 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2016-05-30  8:08 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, May 26, 2016 at 07:25:22PM -0000, Michal Suchanek wrote:
> Used on A10s Olinuxino.
> 
> Signed-off-by: Michal Suchanek <hramrach@gmail.com>

Applied, thanks!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160530/b48ffbe5/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/3] ARM: dts: sun5i: add spi2 on A10s Olinuxino Micro
  2016-05-26 19:25 ` [PATCH 2/3] ARM: dts: sun5i: add spi2 on A10s Olinuxino Micro Michal Suchanek
@ 2016-05-30  8:09   ` Maxime Ripard
  0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2016-05-30  8:09 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On Thu, May 26, 2016 at 07:25:23PM -0000, Michal Suchanek wrote:
> spi2 is available on the UEXT connector
> 
> Signed-off-by: Michal Suchanek <hramrach@gmail.com>
> ---
>  arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts b/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts
> index 86d046a..7d2ff60 100644
> --- a/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts
> +++ b/arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts
> @@ -192,6 +192,13 @@
>  	status = "okay";
>  };
>  
> +&spi2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&spi2_pins_a>,
> +		    <&spi2_cs0_pins_a>;
> +	status = "okay";
> +};
> +

This should be ordered alphabetically.

Fixed it, and applied.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160530/c59b2662/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 3/3] ARM: dts: sun5i: Add spi2 alias on A10s Olinuxino
  2016-05-26 19:25 ` [PATCH 3/3] ARM: dts: sun5i: Add spi2 alias on A10s Olinuxino Michal Suchanek
@ 2016-05-30  8:29   ` Maxime Ripard
  0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2016-05-30  8:29 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, May 26, 2016 at 07:25:24PM -0000, Michal Suchanek wrote:
> spi2 is available on the UEXT connector
> 
> The bus is named spi2 in the A10s manual and Olinuxino manual so it is
> pointless to alias it to something else like spi0.

That's not how aliases work in the DT. It's about indexing the devices
that are enabled on the board, so it should definitely be 0,
especially since it's the only SPI bus usable on that board anyway.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160530/b64821f6/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-05-30  8:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-26 19:25 [PATCH 1/3] ARM: dts: sun5i: a10s: add spi2 pins Michal Suchanek
2016-05-26 19:25 ` [PATCH 2/3] ARM: dts: sun5i: add spi2 on A10s Olinuxino Micro Michal Suchanek
2016-05-30  8:09   ` Maxime Ripard
2016-05-26 19:25 ` [PATCH 3/3] ARM: dts: sun5i: Add spi2 alias on A10s Olinuxino Michal Suchanek
2016-05-30  8:29   ` Maxime Ripard
2016-05-30  8:08 ` [PATCH 1/3] ARM: dts: sun5i: a10s: add spi2 pins Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).