From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: Possible race between PTRACE_SETVFPREGS and PTRACE_CONT on ARM?
Date: Thu, 2 Jun 2016 14:15:39 +0100 [thread overview]
Message-ID: <20160602131539.GA30141@n2100.armlinux.org.uk> (raw)
In-Reply-To: <574EDAED.1050902@ericsson.com>
On Wed, Jun 01, 2016 at 08:54:05AM -0400, Simon Marchi wrote:
> On 16-05-30 05:35 PM, Russell King - ARM Linux wrote:
> > So, the gdb verisons I have here seem to be particularly poor - but with
> > some modifications, I can test out on iMX6 by forcing gdb to do the right
> > thing - by inserting a couple of "mov r0, r0" instructions after the
> > "break_here" label.
>
> I see that problem too with older versions, bisecting shows it has been fixed
> in commit
>
> 6e22494e5076 Do not skip prologue for asm (.S) files
>
> in gdb, which is included in gdb 7.10 and up.
>
> > With that, on a single CPU, it seems to work correctly every time, but
> > if I bring up a secondary CPU I start seeing the same problems you've
> > reported - which seems to need the following patch to solve. Please can
> > you check whether this resolves your problem?
>
> Yes that fixes the problem, the test case succeeds every time. I have stared
> at those lines in ptrace.c for some time, but couldn't find the problem. Thanks
> for looking into it!
Hi, can I add a:
Tested-by: Simon Marchi <simon.marchi@ericsson.com>
tag to the commit please?
Many thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-06-02 13:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 17:48 Possible race between PTRACE_SETVFPREGS and PTRACE_CONT on ARM? Simon Marchi
2016-05-30 21:35 ` Russell King - ARM Linux
2016-05-30 22:40 ` Russell King - ARM Linux
2016-05-31 13:52 ` Will Deacon
2016-05-31 14:18 ` Russell King - ARM Linux
2016-06-01 12:54 ` Simon Marchi
2016-06-02 13:15 ` Russell King - ARM Linux [this message]
2016-06-02 13:17 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602131539.GA30141@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).