From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: fix the wrong comment
Date: Thu, 2 Jun 2016 19:09:48 +0100 [thread overview]
Message-ID: <20160602180948.GE7697@arm.com> (raw)
In-Reply-To: <1464574369-22618-1-git-send-email-shijie.huang@arm.com>
On Mon, May 30, 2016 at 10:12:49AM +0800, Huang Shijie wrote:
> Currently, we use the 48-bit for the kernel and user by default.
> The comment becomes stale. This patch fixes the wrong comment.
>
> Signed-off-by: Huang Shijie <shijie.huang@arm.com>
> ---
> arch/arm64/mm/proc.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S
> index c431787..421386759 100644
> --- a/arch/arm64/mm/proc.S
> +++ b/arch/arm64/mm/proc.S
> @@ -209,8 +209,8 @@ ENTRY(__cpu_setup)
> bic x0, x0, x5 // clear bits
> orr x0, x0, x6 // set bits
> /*
> - * Set/prepare TCR and TTBR. We use 512GB (39-bit) address range for
> - * both user and kernel.
> + * Set/prepare TCR. We use VA_BITS of address range for both
> + * kernel and user.
> */
To be honest, all three of these comments (including the two in the
context) are totally useless. Can we just remove them instead?
Will
next prev parent reply other threads:[~2016-06-02 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 2:12 [PATCH] arm64: fix the wrong comment Huang Shijie
2016-06-02 18:09 ` Will Deacon [this message]
2016-06-03 2:39 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602180948.GE7697@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).