public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding
Date: Mon, 6 Jun 2016 18:29:45 +0100	[thread overview]
Message-ID: <20160606172945.GE23505@leverpostej> (raw)
In-Reply-To: <CACgAJHxMCa2Hp_A8YnHmmVrHGd3yLhFs2k33MN6OHRUmZ7Y_Wg@mail.gmail.com>

On Tue, May 31, 2016 at 06:25:56PM -0700, Tai Tri Nguyen wrote:
> Hi Mark,

[...]

> I'm facing a problem after removing the index for MCU and MC sub-nodes.
> The MCUs and MCs aren't always enabled depending on how DRAM DIMMs are
> installed on the system.
> I still need a way to associate the MCU with its indicator bit in the
> enable mask retrieved from CSR.

Ah, I see.

Can you elaborate on how the indicator bits are laid out? From the
example binding, I see multiple nodes with the same index property, so
I'm a little confused.

I guess that there's a CSR per class of node (e.g. all MCBs in one CSR
register)? Or do several nodes share the same bit?

Is there a single CSR register? Are there several? Is that bit index
used in other registers?

> For MC and MCB nodes only, can I introduce an "enable-mask" field?
> For example:
> "
> pmucmcb at 7e710000 {
>         compatible = "apm,xgene-pmu-mcb";
>         reg = <0x0 0x7e710000 0x0 0x1000>;
>         enable-mask = <0x00000001>;
> };
> 
> pmucmcb at 7e730000 {
>         compatible = "apm,xgene-pmu-mcb";
>         reg = <0x0 0x7e730000 0x0 0x1000>;
>         enable-mask = <0x00000002>;
> };
> "
> Or can you please give a suggestion how I can fix it?

Assuming it's always a single bit, a *-bit-index property may be fine,
and probably preferable.

I'm a little confused, so I'd like to understand how it's used.

Thanks,
Mark.

  reply	other threads:[~2016-06-06 17:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13  1:22 [PATCH v2 0/4] perf: Add APM X-Gene SoC Performance Monitoring Unit driver Tai Nguyen
2016-04-13  1:22 ` [PATCH v2 1/4] MAINTAINERS: Add entry for APM X-Gene SoC PMU driver Tai Nguyen
2016-04-13  1:22 ` [PATCH v2 2/4] Documentation: Add documentation for APM X-Gene SoC PMU DTS binding Tai Nguyen
2016-04-18 17:00   ` Rob Herring
2016-04-18 20:04     ` Tai Tri Nguyen
2016-04-20 11:31       ` Will Deacon
2016-04-29 17:08         ` Tai Tri Nguyen
2016-05-02 20:56         ` Rob Herring
2016-05-02 21:46           ` Tai Tri Nguyen
2016-05-10 23:43             ` Tai Tri Nguyen
2016-05-24 21:12               ` Tai Tri Nguyen
2016-05-31 16:25                 ` Will Deacon
2016-05-31 17:18                   ` Tai Tri Nguyen
2016-05-31 16:56             ` Mark Rutland
2016-05-31 17:17               ` Tai Tri Nguyen
2016-06-01  1:25                 ` Tai Tri Nguyen
2016-06-06 17:29                   ` Mark Rutland [this message]
2016-06-06 17:55                     ` Tai Tri Nguyen
2016-04-13  1:22 ` [PATCH v2 3/4] perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver Tai Nguyen
2016-04-13  1:22 ` [PATCH v2 4/4] arm64: dts: apm: Add APM X-Gene SoC PMU DTS entries Tai Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160606172945.GE23505@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox